From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luc Van Oostenryck Subject: Re: [PATCH 0/7] pull: make smatch scan output easy to digest Date: Sun, 26 Feb 2017 05:07:28 +0100 Message-ID: <20170226040727.vjf6wdy7yiakppx5@macbook.local> References: <20170213220641.1395-1-kerolasa@iki.fi> <20170220121426.5mr6ab6x7pxt5j4b@ws.net.home> <20170221095012.txqxcblrqkmoxktw@ws.net.home> <20170223153049.GC4133@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-wm0-f68.google.com ([74.125.82.68]:35396 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890AbdBZEHb (ORCPT ); Sat, 25 Feb 2017 23:07:31 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: Sami Kerola Cc: Dan Carpenter , Karel Zak , util-linux , linux-sparse@vger.kernel.org On Sat, Feb 25, 2017 at 05:32:23PM +0000, Sami Kerola wrote: > On Fri, 24 Feb 2017, Dan Carpenter wrote: > text-utils/more.c:674:43: error: symbol 'end_it' redeclared with different > type (originally declared at text-utils/more.c:143) - different modifiers > > that are caused by lack of function attributes in declaration, while > fuction has them. Yes, this is a sparse's bug. I hope I'll be able to look at it soon. > See below simple source file that demonstrates how to triggers warning in > question. When I said was 'smatch' printed warnings it was cgcc that was > complaining , and therefore this is not really a 'smatch' problem at all. > Sorry about giving wrong impression. > > When comparing gcc with clang gives very similar warning. Perhaps the > right way to go about this is to reorder attributes to be in front of > functions after all. Luc Van Oostenryck