From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Christopher Li <sparse@chrisli.org>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH v3 6/7] make process_decl() aware of the presence of an initializer
Date: Sun, 5 Mar 2017 16:29:15 +0100 [thread overview]
Message-ID: <20170305152915.vbnm3eho27mueymj@macpro.local> (raw)
In-Reply-To: <CANeU7Qm1oPqK=56=c8q=dtVBr27vF0NufGgCr4Y0RYnyJVfBQg@mail.gmail.com>
On Sun, Mar 05, 2017 at 10:49:37PM +0800, Christopher Li wrote:
> This can be written as:
>
> int has_init = !is_typedef && match_op(token, '=');
> if (has_init) {
Yes, it can.
But honestly I absolutely detest this 'has_init'.
> ....
>
> Passing the "has_init" into a call back function make the code hard to
> read because the logic has separated into two function. At the same time
> process_for_loop_decl does not issue this warning at all, I think it should.
Since I just realize that this 'has_init' is not needed as we can
simply test the presence of decl->initializer, I'll remove it.
> I will apply this patch for sparse-next, I agree the warning is useful
> behavior. I am also expecting a follow up patch.
Yes.
Don't bother to add it to sparse-next, I'll send another version later.
Luc
next prev parent reply other threads:[~2017-03-05 15:29 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 20:30 [PATCH 0/5] more validation of C99 for-loop initializers Luc Van Oostenryck
2017-02-18 20:30 ` [PATCH 1/5] replace test for c99 " Luc Van Oostenryck
2017-02-18 22:37 ` Ramsay Jones
2017-02-19 1:10 ` Luc Van Oostenryck
2017-02-19 20:58 ` Ramsay Jones
2017-02-20 7:20 ` [PATCH v2 0/5] more validation of C99 " Luc Van Oostenryck
2017-02-20 7:20 ` [PATCH v2 1/5] replace test for c99 " Luc Van Oostenryck
2017-02-20 14:05 ` Ramsay Jones
2017-02-20 7:20 ` [PATCH v2 2/5] add test case for scope of C99 for-loop declarations Luc Van Oostenryck
2017-02-20 7:20 ` [PATCH v2 3/5] add test cases for storage of c99 " Luc Van Oostenryck
2017-02-20 7:20 ` [PATCH v2 4/5] add a method to external_declaration() Luc Van Oostenryck
2017-02-20 7:20 ` [PATCH v2 5/5] check the storage of C99 for-loop initializers Luc Van Oostenryck
2017-02-18 20:30 ` [PATCH 2/5] add test case for scope of C99 for-loop declarations Luc Van Oostenryck
2017-02-18 20:30 ` [PATCH 3/5] add test cases for storage of c99 " Luc Van Oostenryck
2017-02-18 20:30 ` [PATCH 4/5] add a method to external_declaration() Luc Van Oostenryck
2017-02-27 15:37 ` Christopher Li
2017-02-27 21:34 ` Luc Van Oostenryck
2017-02-28 9:46 ` Luc Van Oostenryck
2017-02-28 10:03 ` [PATCH v3 0/7] more validation of C99 for-loop initializers Luc Van Oostenryck
2017-02-28 10:03 ` [PATCH v3 1/7] replace test for c99 " Luc Van Oostenryck
2017-02-28 10:03 ` [PATCH v3 2/7] add test case for scope of C99 for-loop declarations Luc Van Oostenryck
2017-02-28 10:03 ` [PATCH v3 3/7] add test cases for storage of c99 " Luc Van Oostenryck
2017-02-28 10:04 ` [PATCH v3 4/7] add a method to external_declaration() Luc Van Oostenryck
2017-03-05 14:04 ` Christopher Li
2017-03-05 15:12 ` Luc Van Oostenryck
2017-03-06 1:13 ` Christopher Li
2017-03-05 19:21 ` [PATCH v4 0/6] more validation of C99 for-loop initializers Luc Van Oostenryck
2017-03-05 19:21 ` [PATCH v4 1/6] replace test for c99 " Luc Van Oostenryck
2017-03-05 19:21 ` [PATCH v4 2/6] add test case for scope of C99 for-loop declarations Luc Van Oostenryck
2017-03-05 19:21 ` [PATCH v4 3/6] add test cases for storage of c99 " Luc Van Oostenryck
2017-03-05 19:21 ` [PATCH v4 4/6] add an optional validation method to external_declaration() Luc Van Oostenryck
2017-03-05 19:21 ` [PATCH v4 5/6] check the storage of C99 for-loop initializers Luc Van Oostenryck
2017-03-05 19:21 ` [PATCH v4 6/6] move 'extern with initializer' validation after the validate method Luc Van Oostenryck
2017-03-06 0:59 ` [PATCH v4 0/6] more validation of C99 for-loop initializers Christopher Li
2017-03-06 1:08 ` Luc Van Oostenryck
2017-02-28 10:04 ` [PATCH v3 5/7] check the storage " Luc Van Oostenryck
2017-03-05 14:26 ` Christopher Li
2017-03-05 15:24 ` Luc Van Oostenryck
2017-02-28 10:04 ` [PATCH v3 6/7] make process_decl() aware of the presence of an initializer Luc Van Oostenryck
2017-03-05 14:49 ` Christopher Li
2017-03-05 15:29 ` Luc Van Oostenryck [this message]
2017-02-28 10:04 ` [PATCH v3 7/7] move check extern with initializer to default_process_decl() Luc Van Oostenryck
2017-02-28 16:34 ` [PATCH v3 0/7] more validation of C99 for-loop initializers Christopher Li
2017-02-28 16:40 ` Luc Van Oostenryck
2017-02-18 20:30 ` [PATCH 5/5] check the storage " Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170305152915.vbnm3eho27mueymj@macpro.local \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).