sparse-llvm switch constants must all be same type as switch value

sparse-llvm switch constants must all be same type as switch value

[Dibyendu Majumdar]

Hi,

While investigating errors that occurred when compiling 'minilua' I
found that the sparse-llvm output for switch statements is hard coded
to generate int32 values even when the switch is on a different
integer type. I believe following fix is needed in output_op_switch():

 FOR_EACH_PTR(insn->multijmp_list, jmp) {
  if (jmp->begin == jmp->end) {  /* case N */
   LLVMAddCase(target,
    LLVMConstInt(LLVMTypeOf(sw_val), jmp->begin, 0),
    jmp->target->priv);
  } else if (jmp->begin < jmp->end) { /* case M..N */
   assert(0);
  }
 } END_FOR_EACH_PTR(jmp);

Re: sparse-llvm switch constants must all be same type as switch value

[Luc Van Oostenryck]

On Mon, Mar 13, 2017 at 09:24:47PM +0000, Dibyendu Majumdar wrote:
> Hi,
> 
> While investigating errors that occurred when compiling 'minilua' I
> found that the sparse-llvm output for switch statements is hard coded
> to generate int32 values even when the switch is on a different
> integer type. I believe following fix is needed in output_op_switch():
> 
>  FOR_EACH_PTR(insn->multijmp_list, jmp) {
>   if (jmp->begin == jmp->end) {  /* case N */
>    LLVMAddCase(target,
>     LLVMConstInt(LLVMTypeOf(sw_val), jmp->begin, 0),
>     jmp->target->priv);
>   } else if (jmp->begin < jmp->end) { /* case M..N */
>    assert(0);
>   }
>  } END_FOR_EACH_PTR(jmp);

There is also a problem with signed/unsigned constants,
like everywhere else in the code.

Could you submit a test case for this?

-- Luc

Re: sparse-llvm switch constants must all be same type as switch value

[Dibyendu Majumdar]

On 19 March 2017 at 00:52, Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
> On Mon, Mar 13, 2017 at 09:24:47PM +0000, Dibyendu Majumdar wrote:
>>
>> While investigating errors that occurred when compiling 'minilua' I
>> found that the sparse-llvm output for switch statements is hard coded
>> to generate int32 values even when the switch is on a different
>> integer type.
>
> Could you submit a test case for this?
>

extern int printf(const char *, ...);
int main(int argc, const char *argv[])
{
 const char *cp = argv[0];
 switch (*cp) {
 case 's':
  printf("%c\n", *cp);
  break;
 default:
  if (*cp)
   printf("%c\n", *cp);
  break;
 }
 return 0;
}

Re: sparse-llvm switch constants must all be same type as switch value

[Luc Van Oostenryck]

On Sun, Mar 19, 2017 at 12:31:27PM +0000, Dibyendu Majumdar wrote:
> On 19 March 2017 at 00:52, Luc Van Oostenryck
> <luc.vanoostenryck@gmail.com> wrote:
> > On Mon, Mar 13, 2017 at 09:24:47PM +0000, Dibyendu Majumdar wrote:
> >>
> >> While investigating errors that occurred when compiling 'minilua' I
> >> found that the sparse-llvm output for switch statements is hard coded
> >> to generate int32 values even when the switch is on a different
> >> integer type.

This is fixed in the llvm-fixes-v3 serie I submitted yesterday.

-- Luc