From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Christopher Li <sparse@chrisli.org>
Subject: [PATCH 6/7] fix evaluation of a function or array symbol in conditionals
Date: Wed, 22 Mar 2017 18:32:56 +0100 [thread overview]
Message-ID: <20170322173257.63019-7-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20170322173257.63019-1-luc.vanoostenryck@gmail.com>
Functions and arrays degenerate as pointers in most context
but this wasn't done in the case of conditionals.
As a result the value of the conditional after linearization
was invalid.
Fix this by calling degenerate() in evaluate_conditional().
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
evaluate.c | 1 +
validation/cond-address.c | 14 ++++++++++++++
2 files changed, 15 insertions(+)
create mode 100644 validation/cond-address.c
diff --git a/evaluate.c b/evaluate.c
index f2d95c79d..976857915 100644
--- a/evaluate.c
+++ b/evaluate.c
@@ -881,6 +881,7 @@ static struct symbol *evaluate_conditional(struct expression *expr, int iterator
ctype = NULL;
}
}
+ ctype = degenerate(expr);
return ctype;
}
diff --git a/validation/cond-address.c b/validation/cond-address.c
new file mode 100644
index 000000000..2a69f4b92
--- /dev/null
+++ b/validation/cond-address.c
@@ -0,0 +1,14 @@
+extern void f(void);
+extern int a[];
+
+int foo(void) { if (f) return 1; return 0; }
+int bar(void) { if (a) return 1; return 0; }
+int qux(void) { if (f && a) return 1; return 0; }
+
+/*
+ * check-name: cond-address.c
+ * check-command: test-linearize -Wno-decl $file
+ * check-output-ignore
+ *
+ * check-excludes: VOID
+ */
--
2.12.0
next prev parent reply other threads:[~2017-03-22 17:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 17:32 [PATCH 0/7] fix function or array address in conditionals Luc Van Oostenryck
2017-03-22 17:32 ` [PATCH 1/7] teach sparse about -Waddress Luc Van Oostenryck
2017-03-22 17:32 ` [PATCH 2/7] add is_func_type() Luc Van Oostenryck
2017-03-22 17:32 ` [PATCH 3/7] warn if testing the address of a function Luc Van Oostenryck
2017-03-22 17:32 ` [PATCH 4/7] add is_array_type() Luc Van Oostenryck
2017-03-22 17:32 ` [PATCH 5/7] warn if testing the address of an array Luc Van Oostenryck
2017-03-22 17:32 ` Luc Van Oostenryck [this message]
2017-03-22 17:32 ` [PATCH 7/7] fix is_scalar_type() Luc Van Oostenryck
2017-04-01 10:36 ` [GIT PULL] fix function or array address in conditionals Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322173257.63019-7-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).