From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Christopher Li <sparse@chrisli.org>
Subject: [PATCH 7/7] fix is_scalar_type()
Date: Wed, 22 Mar 2017 18:32:57 +0100 [thread overview]
Message-ID: <20170322173257.63019-8-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20170322173257.63019-1-luc.vanoostenryck@gmail.com>
This helper was introduced to add some warning in conditionals
which must accept arrays and functions as those degenerate as
pointers in this context.
There was some sign of a bug somewhere but it wasn't seen
and as consequence arrays and function type were added to
scalar type (yeah, brown paper bag).
Now that the bug is solved, fix this by removing array and
function type from is_scalar_type().
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
symbol.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/symbol.h b/symbol.h
index 512a2f69f..327449611 100644
--- a/symbol.h
+++ b/symbol.h
@@ -395,8 +395,6 @@ static inline int is_scalar_type(struct symbol *type)
case SYM_ENUM:
case SYM_BITFIELD:
case SYM_PTR:
- case SYM_ARRAY: // OK, will be a PTR after conversion
- case SYM_FN:
case SYM_RESTRICT: // OK, always integer types
return 1;
default:
--
2.12.0
next prev parent reply other threads:[~2017-03-22 17:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 17:32 [PATCH 0/7] fix function or array address in conditionals Luc Van Oostenryck
2017-03-22 17:32 ` [PATCH 1/7] teach sparse about -Waddress Luc Van Oostenryck
2017-03-22 17:32 ` [PATCH 2/7] add is_func_type() Luc Van Oostenryck
2017-03-22 17:32 ` [PATCH 3/7] warn if testing the address of a function Luc Van Oostenryck
2017-03-22 17:32 ` [PATCH 4/7] add is_array_type() Luc Van Oostenryck
2017-03-22 17:32 ` [PATCH 5/7] warn if testing the address of an array Luc Van Oostenryck
2017-03-22 17:32 ` [PATCH 6/7] fix evaluation of a function or array symbol in conditionals Luc Van Oostenryck
2017-03-22 17:32 ` Luc Van Oostenryck [this message]
2017-04-01 10:36 ` [GIT PULL] fix function or array address " Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322173257.63019-8-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).