From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Ramsay Jones <ramsay@ramsayjones.plus.com>,
Christopher Li <sparse@chrisli.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH 5/5] do not depends on limits.h to test __CHAR_BIT__
Date: Mon, 27 Mar 2017 16:19:18 +0200 [thread overview]
Message-ID: <20170327141918.61151-6-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20170327141918.61151-1-luc.vanoostenryck@gmail.com>
This test depends on the header <limits.h> which itself depends
on some macros being defined by the compiler.
Now these macros are predefined (at least the obvious ones)
but it's annoying for the tests to depends on external things
like this header.
Remove this dependence by rewriting the test to use the predefined
macros directly.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
validation/builtin_char_bit.c | 7 -------
validation/preprocessor/predef-char-bit.c | 16 ++++++++++++++++
2 files changed, 16 insertions(+), 7 deletions(-)
delete mode 100644 validation/builtin_char_bit.c
create mode 100644 validation/preprocessor/predef-char-bit.c
diff --git a/validation/builtin_char_bit.c b/validation/builtin_char_bit.c
deleted file mode 100644
index 30e6bed46..000000000
--- a/validation/builtin_char_bit.c
+++ /dev/null
@@ -1,7 +0,0 @@
-#include <limits.h>
-
-static unsigned int word_bits = sizeof(unsigned int) * CHAR_BIT;
-
-/*
- * check-name: __CHAR_BIT__
- */
diff --git a/validation/preprocessor/predef-char-bit.c b/validation/preprocessor/predef-char-bit.c
new file mode 100644
index 000000000..fed0166e4
--- /dev/null
+++ b/validation/preprocessor/predef-char-bit.c
@@ -0,0 +1,16 @@
+#define TEST_BIT(X, T) if (__ ## X ## _BIT__ != 8 * sizeof(T)) return 1
+
+int test(void)
+{
+ TEST_BIT(CHAR, char);
+
+ return 0;
+}
+
+/*
+ * check-name: predefined __<type>_BIT__
+ * check-command: test-linearize -Wno-decl $file
+ * check-output-ignore
+ *
+ * check-output-contains: ret\\..*\\$0
+ */
--
2.12.0
next prev parent reply other threads:[~2017-03-27 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 14:19 [PATCH 0/5] fix test cases on 32bit Luc Van Oostenryck
2017-03-27 14:19 ` [PATCH 1/5] fix test for cast to bool on 32bit machines Luc Van Oostenryck
2017-03-27 14:19 ` [PATCH 2/5] predefine __INT_MAX__ and friends Luc Van Oostenryck
2017-03-27 14:19 ` [PATCH 3/5] predefine __SIZEOF_INT__ & friends Luc Van Oostenryck
2017-03-27 14:19 ` [PATCH 4/5] fix test validation/div.c Luc Van Oostenryck
2017-03-27 14:19 ` Luc Van Oostenryck [this message]
2017-04-01 10:32 ` [GIT PULL] fix test cases on 32bit Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327141918.61151-6-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=ramsay@ramsayjones.plus.com \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).