From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH 6/6] testsuite: avoid fork+execing basename
Date: Sun, 28 May 2017 21:29:06 +0200 [thread overview]
Message-ID: <20170528192906.1023-7-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20170528192906.1023-1-luc.vanoostenryck@gmail.com>
Some testcase (the ones related to sparse-llvm) are disabled if
the needed support is not present. This is done by checking
the name of the command used by the testcase.
The previous possible presence of './' before the command meant
that the command was checked via the 'basename' command, which
need to ne fork+execed.
Since the './' have now been stripped from all command names
this is no more needed.
Change this by comparing directly the command name.
This speedup the testsuite by another 6%.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
validation/test-suite | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/validation/test-suite b/validation/test-suite
index da9d88159..3056fce90 100755
--- a/validation/test-suite
+++ b/validation/test-suite
@@ -189,11 +189,10 @@ do_test()
if [ "$check_command" = "" ]; then
check_command="$defaut_command"
fi
- cmd=`eval echo $default_path/$check_command`
# check for disabled commands
- set -- $cmd
- base_cmd=`basename $1`
+ set -- $check_command
+ base_cmd=$1
for i in $disabled_cmds; do
if [ "$i" = "$base_cmd" ] ; then
disabled_tests=$(($disabled_tests + 1))
@@ -202,6 +201,8 @@ do_test()
fi
done
+ cmd=`eval echo $default_path/$check_command`
+
echo " TEST $test_name ($file)"
verbose "Using command : $cmd"
--
2.13.0
next prev parent reply other threads:[~2017-05-28 19:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-28 19:29 [PATCH 0/6] testsuite speedup Luc Van Oostenryck
2017-05-28 19:29 ` [PATCH 1/6] testsuite: get all tags in once Luc Van Oostenryck
2017-05-28 19:29 ` [PATCH 2/6] testsuite: grep the expected output only when needed Luc Van Oostenryck
2017-05-28 19:29 ` [PATCH 3/6] testsuite: grep the output patterns " Luc Van Oostenryck
2017-05-28 19:29 ` [PATCH 4/6] testsuite: use shell arithmetic instead of fork-execing expr Luc Van Oostenryck
2017-05-28 19:29 ` [PATCH 5/6] testsuite: remove unneeded './' before commands Luc Van Oostenryck
2017-05-28 19:29 ` Luc Van Oostenryck [this message]
2017-05-28 22:04 ` [PATCH 0/6] testsuite speedup Ramsay Jones
2017-05-28 22:39 ` Luc Van Oostenryck
2017-05-29 1:44 ` Ramsay Jones
2017-06-01 9:16 ` Christopher Li
2017-06-01 14:05 ` Luc Van Oostenryck
2017-06-02 7:29 ` Christopher Li
2017-06-02 10:57 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170528192906.1023-7-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).