* [PATCH 1/9] add is_pseudo_value()
2017-05-31 3:21 [PATCH 0/9] division by zero warnings Luc Van Oostenryck
@ 2017-05-31 3:21 ` Luc Van Oostenryck
2017-05-31 3:22 ` [PATCH 2/9] add a .warned field to struct instruction Luc Van Oostenryck
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Luc Van Oostenryck @ 2017-05-31 3:21 UTC (permalink / raw)
To: linux-sparse; +Cc: Luc Van Oostenryck
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
linearize.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/linearize.h b/linearize.h
index bac82d7ff..c704b87b4 100644
--- a/linearize.h
+++ b/linearize.h
@@ -45,6 +45,13 @@ extern struct pseudo void_pseudo;
#define VOID (&void_pseudo)
+
+static inline int is_pseudo_value(pseudo_t p, long long value)
+{
+ return p->type == PSEUDO_VAL && p->value == value;
+}
+
+
struct multijmp {
struct basic_block *target;
int begin, end;
--
2.13.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/9] add a .warned field to struct instruction
2017-05-31 3:21 [PATCH 0/9] division by zero warnings Luc Van Oostenryck
2017-05-31 3:21 ` [PATCH 1/9] add is_pseudo_value() Luc Van Oostenryck
@ 2017-05-31 3:22 ` Luc Van Oostenryck
2017-05-31 3:22 ` [PATCH 3/9] div0: warn on integer divide by 0 also when the lhs is not constant Luc Van Oostenryck
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Luc Van Oostenryck @ 2017-05-31 3:22 UTC (permalink / raw)
To: linux-sparse; +Cc: Luc Van Oostenryck
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
linearize.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/linearize.h b/linearize.h
index c704b87b4..2b6cb0c86 100644
--- a/linearize.h
+++ b/linearize.h
@@ -75,8 +75,9 @@ struct asm_rules {
DECLARE_ALLOCATOR(asm_rules);
struct instruction {
- unsigned opcode:8,
- size:24;
+ unsigned opcode:7;
+ unsigned warned:1;
+ unsigned size:24;
struct basic_block *bb;
struct position pos;
struct symbol *type;
--
2.13.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/9] div0: warn on integer divide by 0 also when the lhs is not constant
2017-05-31 3:21 [PATCH 0/9] division by zero warnings Luc Van Oostenryck
2017-05-31 3:21 ` [PATCH 1/9] add is_pseudo_value() Luc Van Oostenryck
2017-05-31 3:22 ` [PATCH 2/9] add a .warned field to struct instruction Luc Van Oostenryck
@ 2017-05-31 3:22 ` Luc Van Oostenryck
2017-05-31 3:22 ` [PATCH 4/9] div0: warn on division by zero - general case Luc Van Oostenryck
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Luc Van Oostenryck @ 2017-05-31 3:22 UTC (permalink / raw)
To: linux-sparse; +Cc: Luc Van Oostenryck
The current code detects and warns on division by zero but
only when the left-hand side is a constant value.
Fix that by moving up the code which detect such divisions
before checking if the LHS is a constant.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
expand.c | 8 ++------
validation/div-by-zero.c | 43 +++++++++++++++++++++++++++++++++++++++++++
2 files changed, 45 insertions(+), 6 deletions(-)
create mode 100644 validation/div-by-zero.c
diff --git a/expand.c b/expand.c
index 5f908c971..0b528ea5a 100644
--- a/expand.c
+++ b/expand.c
@@ -181,6 +181,8 @@ static int simplify_int_binop(struct expression *expr, struct symbol *ctype)
if (right->type != EXPR_VALUE)
return 0;
r = right->value;
+ if (!r && (expr->op == '/' || expr->op == '%'))
+ goto Div;
if (expr->op == SPECIAL_LEFTSHIFT || expr->op == SPECIAL_RIGHTSHIFT) {
if (r >= ctype->bit_size) {
if (conservative)
@@ -235,28 +237,22 @@ static int simplify_int_binop(struct expression *expr, struct symbol *ctype)
break;
case SIGNED('/'):
- if (!r)
- goto Div;
if (l == mask && sr == -1)
goto Overflow;
v = sl / sr;
break;
case UNSIGNED('/'):
- if (!r) goto Div;
v = l / r;
break;
case SIGNED('%'):
- if (!r)
- goto Div;
if (l == mask && sr == -1)
goto Overflow;
v = sl % sr;
break;
case UNSIGNED('%'):
- if (!r) goto Div;
v = l % r;
break;
diff --git a/validation/div-by-zero.c b/validation/div-by-zero.c
new file mode 100644
index 000000000..786e48298
--- /dev/null
+++ b/validation/div-by-zero.c
@@ -0,0 +1,43 @@
+int scdiv(int a) { return 2 / 0; }
+int iscdiv(int a) { return 2 / (int) 0; }
+int lscdiv(int a) { return 2 / (long) 0; }
+int uscdiv(int a) { return 2 / (unsigned int) 0; }
+
+int svdiv(int a) { return a / 0; }
+int isvdiv(int a) { return a / (int) 0; }
+int lsvdiv(int a) { return a / (long) 0; }
+int usvdiv(int a) { return a / (unsigned int) 0; }
+
+int scmod(int a) { return 2 % 0; }
+int iscmod(int a) { return 2 % (int) 0; }
+int lscmod(int a) { return 2 % (long) 0; }
+int uscmod(int a) { return 2 % (unsigned int) 0; }
+
+int svmod(int a) { return a % 0; }
+int isvmod(int a) { return a % (int) 0; }
+int lsvmod(int a) { return a % (long) 0; }
+int usvmod(int a) { return a % (unsigned int) 0; }
+
+/*
+ * check-name: div-by-zero.c
+ * check-command: sparse -Wno-decl $file
+ *
+ * check-error-start
+div-by-zero.c:1:30: warning: division by zero
+div-by-zero.c:2:30: warning: division by zero
+div-by-zero.c:3:30: warning: division by zero
+div-by-zero.c:4:30: warning: division by zero
+div-by-zero.c:6:30: warning: division by zero
+div-by-zero.c:7:30: warning: division by zero
+div-by-zero.c:8:30: warning: division by zero
+div-by-zero.c:9:30: warning: division by zero
+div-by-zero.c:11:30: warning: division by zero
+div-by-zero.c:12:30: warning: division by zero
+div-by-zero.c:13:30: warning: division by zero
+div-by-zero.c:14:30: warning: division by zero
+div-by-zero.c:16:30: warning: division by zero
+div-by-zero.c:17:30: warning: division by zero
+div-by-zero.c:18:30: warning: division by zero
+div-by-zero.c:19:30: warning: division by zero
+ * check-error-end
+ */
--
2.13.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 4/9] div0: warn on division by zero - general case
2017-05-31 3:21 [PATCH 0/9] division by zero warnings Luc Van Oostenryck
` (2 preceding siblings ...)
2017-05-31 3:22 ` [PATCH 3/9] div0: warn on integer divide by 0 also when the lhs is not constant Luc Van Oostenryck
@ 2017-05-31 3:22 ` Luc Van Oostenryck
2017-05-31 3:22 ` [PATCH 5/9] div0: add warning option -Wdiv-by-zero Luc Van Oostenryck
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Luc Van Oostenryck @ 2017-05-31 3:22 UTC (permalink / raw)
To: linux-sparse; +Cc: Luc Van Oostenryck
sparse warn about division by zero but only in plain
expression: no checks are done when the division is
part of a compound assignement.
Change this by adding the appropriate check and warning
during linearization and take care to avoid warning twice.
Note: if should be simpler to drop the checks done at
expansion time but some expressions are discarded
before reaching linearization and we want to check
and warn for those too.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
linearize.c | 19 +++++++++++++++++++
validation/div-by-zero.c | 12 ++++++++++++
2 files changed, 31 insertions(+)
diff --git a/linearize.c b/linearize.c
index 7313e72d8..7760ea996 100644
--- a/linearize.c
+++ b/linearize.c
@@ -959,6 +959,23 @@ static pseudo_t linearize_store_gen(struct entrypoint *ep,
return value;
}
+static void warn_undef_insn(struct instruction *insn, int warn)
+{
+ switch (insn->opcode) {
+ case OP_DIVU:
+ case OP_DIVS:
+ case OP_MODU:
+ case OP_MODS:
+ if (is_pseudo_value(insn->src2, 0)) {
+ if (warn)
+ warning(insn->pos, "division by zero");
+ }
+ break;
+ default:
+ break;
+ }
+}
+
static pseudo_t add_binary_op(struct entrypoint *ep, struct symbol *ctype, int op, pseudo_t left, pseudo_t right)
{
struct instruction *insn = alloc_typed_instruction(op, ctype);
@@ -1208,6 +1225,7 @@ static pseudo_t linearize_assignment(struct entrypoint *ep, struct expression *e
oldvalue = cast_pseudo(ep, oldvalue, target->ctype, ctype);
opcode = opcode_sign(op_trans[expr->op - SPECIAL_BASE], ctype);
dst = add_binary_op(ep, ctype, opcode, oldvalue, value);
+ warn_undef_insn(dst->def, 1);
value = cast_pseudo(ep, dst, ctype, expr->ctype);
}
value = linearize_store_gen(ep, value, &ad);
@@ -1323,6 +1341,7 @@ static pseudo_t linearize_binop(struct entrypoint *ep, struct expression *expr)
src2 = linearize_expression(ep, expr->right);
op = opcode_sign(opcode[expr->op], expr->ctype);
dst = add_binary_op(ep, expr->ctype, op, src1, src2);
+ warn_undef_insn(dst->def, 0);
return dst;
}
diff --git a/validation/div-by-zero.c b/validation/div-by-zero.c
index 786e48298..a06944a58 100644
--- a/validation/div-by-zero.c
+++ b/validation/div-by-zero.c
@@ -18,6 +18,14 @@ int isvmod(int a) { return a % (int) 0; }
int lsvmod(int a) { return a % (long) 0; }
int usvmod(int a) { return a % (unsigned int) 0; }
+int xsvdiv(int a) { if (a && 0) return a / 0; return 0; }
+int asvdiv(int a) { return a /= 0; }
+int osvdiv(int a) { return a / (a && 0); }
+
+int xsvmod(int a) { if (a && 0) return a % 0; return 0; }
+int asvmod(int a) { return a %= 0; }
+int osvmod(int a) { return a % (a && 0); }
+
/*
* check-name: div-by-zero.c
* check-command: sparse -Wno-decl $file
@@ -39,5 +47,9 @@ div-by-zero.c:16:30: warning: division by zero
div-by-zero.c:17:30: warning: division by zero
div-by-zero.c:18:30: warning: division by zero
div-by-zero.c:19:30: warning: division by zero
+div-by-zero.c:21:42: warning: division by zero
+div-by-zero.c:22:33: warning: division by zero
+div-by-zero.c:25:42: warning: division by zero
+div-by-zero.c:26:33: warning: division by zero
* check-error-end
*/
--
2.13.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 5/9] div0: add warning option -Wdiv-by-zero
2017-05-31 3:21 [PATCH 0/9] division by zero warnings Luc Van Oostenryck
` (3 preceding siblings ...)
2017-05-31 3:22 ` [PATCH 4/9] div0: warn on division by zero - general case Luc Van Oostenryck
@ 2017-05-31 3:22 ` Luc Van Oostenryck
2017-05-31 3:22 ` [PATCH 6/9] div0: use -Wdiv-by-zero Luc Van Oostenryck
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Luc Van Oostenryck @ 2017-05-31 3:22 UTC (permalink / raw)
To: linux-sparse; +Cc: Luc Van Oostenryck
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
lib.c | 2 ++
lib.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/lib.c b/lib.c
index e1e6a1cbf..af2ad83a2 100644
--- a/lib.c
+++ b/lib.c
@@ -225,6 +225,7 @@ int Wdecl = 1;
int Wdeclarationafterstatement = -1;
int Wdefault_bitfield_sign = 0;
int Wdesignated_init = 1;
+int Wdiv_by_zero = 1;
int Wdo_while = 0;
int Winit_cstring = 0;
int Wenum_mismatch = 1;
@@ -502,6 +503,7 @@ static const struct warning {
{ "declaration-after-statement", &Wdeclarationafterstatement },
{ "default-bitfield-sign", &Wdefault_bitfield_sign },
{ "designated-init", &Wdesignated_init },
+ { "div-by-zero", &Wdiv_by_zero },
{ "do-while", &Wdo_while },
{ "enum-mismatch", &Wenum_mismatch },
{ "sparse-error", &Wsparse_error },
diff --git a/lib.h b/lib.h
index 2c8529f93..820e69476 100644
--- a/lib.h
+++ b/lib.h
@@ -112,6 +112,7 @@ extern int Wdecl;
extern int Wdeclarationafterstatement;
extern int Wdefault_bitfield_sign;
extern int Wdesignated_init;
+extern int Wdiv_by_zero;
extern int Wdo_while;
extern int Wenum_mismatch;
extern int Wsparse_error;
--
2.13.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 6/9] div0: use -Wdiv-by-zero
2017-05-31 3:21 [PATCH 0/9] division by zero warnings Luc Van Oostenryck
` (4 preceding siblings ...)
2017-05-31 3:22 ` [PATCH 5/9] div0: add warning option -Wdiv-by-zero Luc Van Oostenryck
@ 2017-05-31 3:22 ` Luc Van Oostenryck
2017-05-31 3:22 ` [PATCH 7/9] div0: warn also during simplification Luc Van Oostenryck
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Luc Van Oostenryck @ 2017-05-31 3:22 UTC (permalink / raw)
To: linux-sparse; +Cc: Luc Van Oostenryck
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
expand.c | 4 ++--
linearize.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/expand.c b/expand.c
index 0b528ea5a..8fd258e25 100644
--- a/expand.c
+++ b/expand.c
@@ -278,7 +278,7 @@ static int simplify_int_binop(struct expression *expr, struct symbol *ctype)
expr->taint = left->taint | right->taint;
return 1;
Div:
- if (!conservative)
+ if (!conservative && Wdiv_by_zero)
warning(expr->pos, "division by zero");
return 0;
Overflow:
@@ -363,7 +363,7 @@ static int simplify_float_binop(struct expression *expr)
expr->fvalue = res;
return 1;
Div:
- if (!conservative)
+ if (!conservative && Wdiv_by_zero)
warning(expr->pos, "division by zero");
return 0;
}
diff --git a/linearize.c b/linearize.c
index 7760ea996..604a67b82 100644
--- a/linearize.c
+++ b/linearize.c
@@ -967,7 +967,7 @@ static void warn_undef_insn(struct instruction *insn, int warn)
case OP_MODU:
case OP_MODS:
if (is_pseudo_value(insn->src2, 0)) {
- if (warn)
+ if (warn && Wdiv_by_zero)
warning(insn->pos, "division by zero");
}
break;
--
2.13.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 7/9] div0: warn also during simplification
2017-05-31 3:21 [PATCH 0/9] division by zero warnings Luc Van Oostenryck
` (5 preceding siblings ...)
2017-05-31 3:22 ` [PATCH 6/9] div0: use -Wdiv-by-zero Luc Van Oostenryck
@ 2017-05-31 3:22 ` Luc Van Oostenryck
2017-05-31 3:22 ` [PATCH 8/9] div0: warn on float divide by 0 also when the lhs is not constant Luc Van Oostenryck
2017-05-31 3:22 ` [PATCH 9/9] div0: add missing tests for floating point div by zero Luc Van Oostenryck
8 siblings, 0 replies; 10+ messages in thread
From: Luc Van Oostenryck @ 2017-05-31 3:22 UTC (permalink / raw)
To: linux-sparse; +Cc: Luc Van Oostenryck
sparse now warn about divion by zero during linearization
but during simplification some expression can become constants
and so some new divisions by zero can appears.
Warn also on those new and to avoid to warn also here on the old
ones, mark the instructions for wich we have already be warned.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
linearize.c | 1 +
simplify.c | 12 ++++++++++++
validation/div-by-zero.c | 2 ++
3 files changed, 15 insertions(+)
diff --git a/linearize.c b/linearize.c
index 604a67b82..51405539d 100644
--- a/linearize.c
+++ b/linearize.c
@@ -969,6 +969,7 @@ static void warn_undef_insn(struct instruction *insn, int warn)
if (is_pseudo_value(insn->src2, 0)) {
if (warn && Wdiv_by_zero)
warning(insn->pos, "division by zero");
+ insn->warned = 1;
}
break;
default:
diff --git a/simplify.c b/simplify.c
index a141ddd43..40e1c253b 100644
--- a/simplify.c
+++ b/simplify.c
@@ -404,6 +404,15 @@ static int simplify_asr(struct instruction *insn, pseudo_t pseudo, long long val
return 0;
}
+static void check_divide_by_zero(struct instruction *insn, long long value)
+{
+ if (value != 0 || insn->warned)
+ return;
+ if (Wdiv_by_zero)
+ warning(insn->pos, "division by zero");
+ insn->warned = 1;
+}
+
static int simplify_mul_div(struct instruction *insn, long long value)
{
unsigned long long sbit = 1ULL << (insn->size - 1);
@@ -525,9 +534,12 @@ static int simplify_constant_rightside(struct instruction *insn)
case OP_MODU: case OP_MODS:
if (value == 1)
return replace_with_pseudo(insn, value_pseudo(0));
+ check_divide_by_zero(insn, value);
return 0;
case OP_DIVU: case OP_DIVS:
+ check_divide_by_zero(insn, value);
+ /* Fall through */
case OP_MULU: case OP_MULS:
return simplify_mul_div(insn, value);
diff --git a/validation/div-by-zero.c b/validation/div-by-zero.c
index a06944a58..353c85889 100644
--- a/validation/div-by-zero.c
+++ b/validation/div-by-zero.c
@@ -49,7 +49,9 @@ div-by-zero.c:18:30: warning: division by zero
div-by-zero.c:19:30: warning: division by zero
div-by-zero.c:21:42: warning: division by zero
div-by-zero.c:22:33: warning: division by zero
+div-by-zero.c:23:38: warning: division by zero
div-by-zero.c:25:42: warning: division by zero
div-by-zero.c:26:33: warning: division by zero
+div-by-zero.c:27:38: warning: division by zero
* check-error-end
*/
--
2.13.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 8/9] div0: warn on float divide by 0 also when the lhs is not constant
2017-05-31 3:21 [PATCH 0/9] division by zero warnings Luc Van Oostenryck
` (6 preceding siblings ...)
2017-05-31 3:22 ` [PATCH 7/9] div0: warn also during simplification Luc Van Oostenryck
@ 2017-05-31 3:22 ` Luc Van Oostenryck
2017-05-31 3:22 ` [PATCH 9/9] div0: add missing tests for floating point div by zero Luc Van Oostenryck
8 siblings, 0 replies; 10+ messages in thread
From: Luc Van Oostenryck @ 2017-05-31 3:22 UTC (permalink / raw)
To: linux-sparse; +Cc: Luc Van Oostenryck
The current code detects and warns on division by zero but
only when the left-hand side is a constant value.
Fix that by moving up the code which detect such divisions
before checking if the LHS is a constant.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
expand.c | 18 ++++++++++--------
validation/div-by-zero-fp.c | 16 ++++++++++++++++
2 files changed, 26 insertions(+), 8 deletions(-)
create mode 100644 validation/div-by-zero-fp.c
diff --git a/expand.c b/expand.c
index 8fd258e25..dacee7a76 100644
--- a/expand.c
+++ b/expand.c
@@ -325,19 +325,23 @@ static int simplify_float_binop(struct expression *expr)
unsigned long mod = expr->ctype->ctype.modifiers;
long double l, r, res;
- if (left->type != EXPR_FVALUE || right->type != EXPR_FVALUE)
+ if (right->type != EXPR_FVALUE)
return 0;
- l = left->fvalue;
r = right->fvalue;
+ if (!r && expr->op == '/')
+ goto Div;
+
+ if (left->type != EXPR_FVALUE)
+ return 0;
+ l = left->fvalue;
if (mod & MOD_LONGLONG) {
switch (expr->op) {
case '+': res = l + r; break;
case '-': res = l - r; break;
case '*': res = l * r; break;
- case '/': if (!r) goto Div;
- res = l / r; break;
+ case '/': res = l / r; break;
default: return 0;
}
} else if (mod & MOD_LONG) {
@@ -345,8 +349,7 @@ static int simplify_float_binop(struct expression *expr)
case '+': res = (double) l + (double) r; break;
case '-': res = (double) l - (double) r; break;
case '*': res = (double) l * (double) r; break;
- case '/': if (!r) goto Div;
- res = (double) l / (double) r; break;
+ case '/': res = (double) l / (double) r; break;
default: return 0;
}
} else {
@@ -354,8 +357,7 @@ static int simplify_float_binop(struct expression *expr)
case '+': res = (float)l + (float)r; break;
case '-': res = (float)l - (float)r; break;
case '*': res = (float)l * (float)r; break;
- case '/': if (!r) goto Div;
- res = (float)l / (float)r; break;
+ case '/': res = (float)l / (float)r; break;
default: return 0;
}
}
diff --git a/validation/div-by-zero-fp.c b/validation/div-by-zero-fp.c
new file mode 100644
index 000000000..787af1636
--- /dev/null
+++ b/validation/div-by-zero-fp.c
@@ -0,0 +1,16 @@
+double fbad(double a) { return 2.0 / 0; }
+double gbad(double a) { return 2.0 / 0.0; }
+double fool(double a) { return a / 0; }
+double ffoo(double a) { return a / 0.0; }
+
+/*
+ * check-name: div-by-zero-fp.c
+ * check-command: sparse -Wno-decl $file
+ *
+ * check-error-start
+div-by-zero-fp.c:1:36: warning: division by zero
+div-by-zero-fp.c:2:36: warning: division by zero
+div-by-zero-fp.c:3:34: warning: division by zero
+div-by-zero-fp.c:4:34: warning: division by zero
+ * check-error-end
+ */
--
2.13.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 9/9] div0: add missing tests for floating point div by zero
2017-05-31 3:21 [PATCH 0/9] division by zero warnings Luc Van Oostenryck
` (7 preceding siblings ...)
2017-05-31 3:22 ` [PATCH 8/9] div0: warn on float divide by 0 also when the lhs is not constant Luc Van Oostenryck
@ 2017-05-31 3:22 ` Luc Van Oostenryck
8 siblings, 0 replies; 10+ messages in thread
From: Luc Van Oostenryck @ 2017-05-31 3:22 UTC (permalink / raw)
To: linux-sparse; +Cc: Luc Van Oostenryck
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
validation/div-by-zero-fp.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/validation/div-by-zero-fp.c b/validation/div-by-zero-fp.c
index 787af1636..957bc732c 100644
--- a/validation/div-by-zero-fp.c
+++ b/validation/div-by-zero-fp.c
@@ -3,14 +3,22 @@ double gbad(double a) { return 2.0 / 0.0; }
double fool(double a) { return a / 0; }
double ffoo(double a) { return a / 0.0; }
+double fbar(double a) { if (a && 0) a / 0.0; return 0; }
+double fbaz(double a) { return a /= 0.0; }
+double fquz(double a) { return a / (a && 0); }
+
/*
* check-name: div-by-zero-fp.c
* check-command: sparse -Wno-decl $file
+ * check-known-to-fail
*
* check-error-start
div-by-zero-fp.c:1:36: warning: division by zero
div-by-zero-fp.c:2:36: warning: division by zero
div-by-zero-fp.c:3:34: warning: division by zero
div-by-zero-fp.c:4:34: warning: division by zero
+div-by-zero-fp.c:6:39: warning: division by zero
+div-by-zero-fp.c:7:34: warning: division by zero
+div-by-zero-fp.c:8:34: warning: division by zero
* check-error-end
*/
--
2.13.0
^ permalink raw reply related [flat|nested] 10+ messages in thread