linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Chris Li <sparse@chrisli.org>,
	Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH v2 0/8] division-by-zero warnings
Date: Sat,  3 Jun 2017 10:01:27 +0200	[thread overview]
Message-ID: <20170603080135.46477-1-luc.vanoostenryck@gmail.com> (raw)

The goal of this series is to add the 'division by zero'
warnings that are missing. Indeed, sparse only warned about
division by zero when the LHS was a constant. When the LHS
was not a constant (and thus also when the division was part
of a compound assignement) no warning was ever issued.

Note: the floating point division need similar changes
      which will be part of another series.

Changes since v1:
- add the warnins for compound assignments at expansion time too
- code restructuration and simplification
- test cases consolidation


This series is also available in the git repository at:
  git://github.com/lucvoo/sparse.git div-by-zero-v2


Luc Van Oostenryck (8):
  add is_pseudo_value()
  add a .warned field to struct instruction
  div0: warn on integer divide by 0 also when the lhs is not constant
  div0: also check for compound assignments
  div0: add warning option -Wdiv-by-zero
  div0: use -Wdiv-by-zero
  div0: warn also during simplification
  div0: warn on float divide by 0 also when the lhs is not constant

 expand.c                    | 42 +++++++++++++++----------
 lib.c                       |  2 ++
 lib.h                       |  1 +
 linearize.c                 | 17 +++++++++++
 linearize.h                 | 12 ++++++--
 simplify.c                  | 12 ++++++++
 validation/div-by-zero-fp.c | 24 +++++++++++++++
 validation/div-by-zero.c    | 74 +++++++++++++++++++++++++++++++++++++++++++++
 8 files changed, 166 insertions(+), 18 deletions(-)
 create mode 100644 validation/div-by-zero-fp.c
 create mode 100644 validation/div-by-zero.c

-- 
2.13.0


             reply	other threads:[~2017-06-03  8:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-03  8:01 Luc Van Oostenryck [this message]
2017-06-03  8:01 ` [PATCH v2 1/8] add is_pseudo_value() Luc Van Oostenryck
2017-06-03  8:01 ` [PATCH v2 2/8] add a .warned field to struct instruction Luc Van Oostenryck
2017-06-03  8:01 ` [PATCH v2 3/8] div0: warn on integer divide by 0 also when the lhs is not constant Luc Van Oostenryck
2017-06-03  8:01 ` [PATCH v2 4/8] div0: also check for compound assignments Luc Van Oostenryck
2017-06-03  8:01 ` [PATCH v2 5/8] div0: add warning option -Wdiv-by-zero Luc Van Oostenryck
2017-06-03  8:01 ` [PATCH v2 6/8] div0: use -Wdiv-by-zero Luc Van Oostenryck
2017-06-03  8:01 ` [PATCH v2 7/8] div0: warn also during simplification Luc Van Oostenryck
2017-06-03  8:01 ` [PATCH v2 8/8] div0: warn on float divide by 0 also when the lhs is not constant Luc Van Oostenryck
2017-06-05 19:16 ` [PATCH v2 0/8] division-by-zero warnings Christopher Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170603080135.46477-1-luc.vanoostenryck@gmail.com \
    --to=luc.vanoostenryck@gmail.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=sparse@chrisli.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).