From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Chris Li <sparse@chrisli.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH v2 4/8] div0: also check for compound assignments
Date: Sat, 3 Jun 2017 10:01:31 +0200 [thread overview]
Message-ID: <20170603080135.46477-5-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20170603080135.46477-1-luc.vanoostenryck@gmail.com>
---
expand.c | 12 ++++++++++++
validation/div-by-zero.c | 6 ++++++
2 files changed, 18 insertions(+)
diff --git a/expand.c b/expand.c
index 0b528ea5a..5bbab17a9 100644
--- a/expand.c
+++ b/expand.c
@@ -559,6 +559,18 @@ static int expand_assignment(struct expression *expr)
{
expand_expression(expr->left);
expand_expression(expr->right);
+ if (!conservative) {
+ switch (expr->op) {
+ case SPECIAL_DIV_ASSIGN:
+ case SPECIAL_MOD_ASSIGN:
+ if (expr->right->type != EXPR_VALUE)
+ break;
+ if (expr->right->value)
+ break;
+ warning(expr->pos, "division by zero");
+ break;
+ }
+ }
return SIDE_EFFECTS;
}
diff --git a/validation/div-by-zero.c b/validation/div-by-zero.c
index 500ceb8eb..bd8d0dfdf 100644
--- a/validation/div-by-zero.c
+++ b/validation/div-by-zero.c
@@ -59,8 +59,14 @@ div-by-zero.c:17:30: warning: division by zero
div-by-zero.c:18:30: warning: division by zero
div-by-zero.c:19:30: warning: division by zero
div-by-zero.c:21:42: warning: division by zero
+div-by-zero.c:22:30: warning: division by zero
div-by-zero.c:25:42: warning: division by zero
+div-by-zero.c:26:30: warning: division by zero
+div-by-zero.c:29:42: warning: division by zero
+div-by-zero.c:30:42: warning: division by zero
div-by-zero.c:35:37: warning: division by zero
div-by-zero.c:36:37: warning: division by zero
+div-by-zero.c:37:37: warning: division by zero
+div-by-zero.c:38:37: warning: division by zero
* check-error-end
*/
--
2.13.0
next prev parent reply other threads:[~2017-06-03 8:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-03 8:01 [PATCH v2 0/8] division-by-zero warnings Luc Van Oostenryck
2017-06-03 8:01 ` [PATCH v2 1/8] add is_pseudo_value() Luc Van Oostenryck
2017-06-03 8:01 ` [PATCH v2 2/8] add a .warned field to struct instruction Luc Van Oostenryck
2017-06-03 8:01 ` [PATCH v2 3/8] div0: warn on integer divide by 0 also when the lhs is not constant Luc Van Oostenryck
2017-06-03 8:01 ` Luc Van Oostenryck [this message]
2017-06-03 8:01 ` [PATCH v2 5/8] div0: add warning option -Wdiv-by-zero Luc Van Oostenryck
2017-06-03 8:01 ` [PATCH v2 6/8] div0: use -Wdiv-by-zero Luc Van Oostenryck
2017-06-03 8:01 ` [PATCH v2 7/8] div0: warn also during simplification Luc Van Oostenryck
2017-06-03 8:01 ` [PATCH v2 8/8] div0: warn on float divide by 0 also when the lhs is not constant Luc Van Oostenryck
2017-06-05 19:16 ` [PATCH v2 0/8] division-by-zero warnings Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170603080135.46477-5-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).