Linux SPARSE checker discussions
 help / color / mirror / Atom feed
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Christopher Li <sparse@chrisli.org>,
	Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: Sparse release v0.5.1-rc1
Date: Wed, 14 Jun 2017 04:29:36 +0200	[thread overview]
Message-ID: <20170614022934.hwr76bduxnwrnolg@ltop.local> (raw)
In-Reply-To: <2a728714-43f7-3db5-e12a-0fe8440517c7@ramsayjones.plus.com>

On Wed, Jun 14, 2017 at 01:00:02AM +0100, Ramsay Jones wrote:
> 
> 
> On 13/06/17 17:05, Luc Van Oostenryck wrote:
> > On Tue, Jun 13, 2017 at 04:08:23PM +0100, Ramsay Jones wrote:
> >> Luc, I have not actually tested these patches (I was waiting for
> >> something I could git-fetch). I have no doubt they are good, but
> > 
> > This -rc1 is in fact the parent of the mem-max-count mini-series,
> > so you tested it already a bit :)
> 
> Err, ... I don't see those patches as part of the sparse-0.5.1-rc1
> branch (or v0.5.1-rc1/master, ...).

No, they will be part of the -rc2. I just meant that they were
built on top of what is now the -rc1.
 
> >> it just occurred to me that a patch may be missing. I don't recall
> >> seeing a change to cgcc to filter-out the new, sparse only, options.
> >> ie. they need to be added to the check_only_option subroutine (#102).
> > 
> > Indeed, it's really great that you thought about it
> > because since I don't use cgcc myself, I would never
> > have thought about updated it.
> 
> I use it all the time (it's really the main front-end to sparse!)
> with '-no-compile'. In this case, since it doesn't call gcc, the
> lack of this 'options filter' does not matter. However, I'm aware
> that many people use cgcc as a proxy for gcc (which is the _intent_,
> after all), so this needs to be fixed. (So that 'make CC=cgcc ...'
> continues to works).

For people that use it as gcc's proxy, they normally wouldn't
feed it with sparse-only options, so it should also be OK.

Otherwise, I'm a bit curious to know the advantage to using cgcc
as a front-end for sparse. I'm aware of the need to have things
like __LONG_MAX__ be defined or __unix, __linux but I'm wondering
what else is needed.

> > I'll add what is needed and check if anything else is
> > missing there.
> 
> Yeah, it is not just _these_ new options; I think there have been
> several 'sparse only' options added 'recently' which have not been
> filtered out in cgcc. (again only 'sparse only' options need to be
> added to the regex in the check_only_option subroutine).

The last months, I added support for a few new flags but most
are flags also know by GCC (-fmem-report, -Woverride-init,
-Waddress, -dD, -std={c11,gnu11}). The only ones that need
to be filtered-out should be:
* -Wmemcpy-max-count and -fmemcpy-max-count=COUNT
* -fdump-linearize[=...]
but Ill double-check.

-- Luc

  reply	other threads:[~2017-06-14  2:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-12 17:05 Sparse release v0.5.1-rc1 Christopher Li
2017-06-13  4:58 ` Luc Van Oostenryck
2017-06-13 15:08   ` Ramsay Jones
2017-06-13 16:05     ` Luc Van Oostenryck
2017-06-14  0:00       ` Ramsay Jones
2017-06-14  2:29         ` Luc Van Oostenryck [this message]
2017-06-13 17:54   ` Christopher Li
2017-06-14  2:05     ` Luc Van Oostenryck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170614022934.hwr76bduxnwrnolg@ltop.local \
    --to=luc.vanoostenryck@gmail.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=ramsay@ramsayjones.plus.com \
    --cc=sparse@chrisli.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox