From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Christopher Li <sparse@chrisli.org>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH 0/2] list of gcc supported attribute name
Date: Tue, 4 Jul 2017 10:05:19 +0200 [thread overview]
Message-ID: <20170704080518.3c2f6li274qikrcx@ltop.local> (raw)
In-Reply-To: <CANeU7QmC-mpubM+2T-50tqwXbXshpFoYzxg4cTw+t-jQDb-J=g@mail.gmail.com>
On Mon, Jul 03, 2017 at 11:35:59AM -0700, Christopher Li wrote:
> This patch add full list of known gcc supported attributes.
>
> So sparse should not give warning on the legit gcc attribute
> any more.
>
> Test with full kernel allmodeconfig compile with the exact
> same output as before(master branch).
>
> I want to include this two patches in the sparse release 0.5.1.
>
> Git repository here:
> https://git.kernel.org/pub/scm/devel/sparse/sparse.git/log/?h=sparse-next-20170603
I think you meant -20170703 here, not -20170603.
On the mailing list, can you please send the patches inlined,
as, for review, attachements are kinda useless.
In patch 1, in the die() message, I think you meant:
"created with different types"
^ ^
In both patches, your signoff is supposed to contains your name.
Thanks,
-- Luc
next prev parent reply other threads:[~2017-07-04 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 18:35 [PATCH 0/2] list of gcc supported attribute name Christopher Li
2017-07-04 8:05 ` Luc Van Oostenryck [this message]
2017-07-04 15:07 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704080518.3c2f6li274qikrcx@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox