From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Christopher Li <sparse@chrisli.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH 5/5] avoid crash with sym->bb_target == NULL
Date: Thu, 6 Jul 2017 21:19:50 +0200 [thread overview]
Message-ID: <20170706191950.81268-6-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20170706191950.81268-1-luc.vanoostenryck@gmail.com>
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
linearize.c | 5 ++++-
validation/crash-bb_target.c | 10 ++++++++++
2 files changed, 14 insertions(+), 1 deletion(-)
create mode 100644 validation/crash-bb_target.c
diff --git a/linearize.c b/linearize.c
index b76e980dc..d868c4551 100644
--- a/linearize.c
+++ b/linearize.c
@@ -334,6 +334,7 @@ const char *show_instruction(struct instruction *insn)
case OP_SETVAL: {
struct expression *expr = insn->val;
+ struct symbol *sym;
buf += sprintf(buf, "%s <- ", show_pseudo(insn->target));
if (!expr) {
@@ -355,7 +356,9 @@ const char *show_instruction(struct instruction *insn)
buf += sprintf(buf, "%s", show_ident(expr->symbol->ident));
break;
case EXPR_LABEL:
- buf += sprintf(buf, ".L%u", expr->symbol->bb_target->nr);
+ sym = expr->symbol;
+ if (sym->bb_target)
+ buf += sprintf(buf, ".L%u", sym->bb_target->nr);
break;
default:
buf += sprintf(buf, "SETVAL EXPR TYPE %d", expr->type);
diff --git a/validation/crash-bb_target.c b/validation/crash-bb_target.c
new file mode 100644
index 000000000..bc5a3d354
--- /dev/null
+++ b/validation/crash-bb_target.c
@@ -0,0 +1,10 @@
+a() {
+ &&b
+
+/*
+ * check-name: crash bb_target
+ * check-command: test-linearize $file
+ *
+ * check-error-ignore
+ * check-output-ignore
+ */
--
2.13.0
next prev parent reply other threads:[~2017-07-06 19:20 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 19:19 [PATCH 0/5] fixes for rare crashes Luc Van Oostenryck
2017-07-06 19:19 ` [PATCH 1/5] do not corrupt ptrlist while killing unreachable BBs Luc Van Oostenryck
2017-07-07 0:40 ` Christopher Li
2017-07-07 1:18 ` Christopher Li
2017-07-07 1:35 ` Linus Torvalds
2017-07-07 5:15 ` Christopher Li
2017-07-07 8:28 ` Luc Van Oostenryck
2017-07-07 9:06 ` Christopher Li
2017-07-07 9:30 ` Luc Van Oostenryck
2017-07-07 9:54 ` Christopher Li
2017-07-07 13:18 ` Dibyendu Majumdar
2017-07-07 13:25 ` Luc Van Oostenryck
2017-07-07 13:29 ` Dibyendu Majumdar
2017-07-07 13:47 ` Luc Van Oostenryck
2017-07-08 15:43 ` Christopher Li
2017-07-07 9:52 ` Luc Van Oostenryck
2017-07-07 6:07 ` Christopher Li
2017-07-07 5:44 ` Luc Van Oostenryck
2017-07-07 6:02 ` Christopher Li
2017-07-07 6:10 ` Luc Van Oostenryck
2017-07-07 6:27 ` Christopher Li
2017-07-07 7:30 ` Luc Van Oostenryck
2017-07-07 9:19 ` Dibyendu Majumdar
2017-07-07 9:26 ` Dibyendu Majumdar
2017-07-07 9:38 ` Luc Van Oostenryck
2017-07-07 9:41 ` Dibyendu Majumdar
2017-07-07 9:58 ` Christopher Li
2017-07-07 10:08 ` Dibyendu Majumdar
2017-07-07 12:54 ` Christopher Li
2017-07-07 13:01 ` Dibyendu Majumdar
2017-07-07 9:44 ` Christopher Li
2017-07-07 9:46 ` Dibyendu Majumdar
2017-07-07 10:00 ` Luc Van Oostenryck
2017-07-07 6:04 ` Luc Van Oostenryck
2017-07-07 6:18 ` Christopher Li
2017-07-07 7:11 ` Luc Van Oostenryck
2017-07-07 8:25 ` Christopher Li
2017-07-07 8:32 ` Luc Van Oostenryck
2017-07-09 9:07 ` Christopher Li
2017-07-09 10:26 ` Luc Van Oostenryck
2017-07-09 14:44 ` Christopher Li
2017-07-09 16:11 ` Luc Van Oostenryck
2017-07-06 19:19 ` [PATCH 2/5] avoid crash when ep->active is NULL Luc Van Oostenryck
2017-07-19 22:20 ` Luc Van Oostenryck
2017-07-20 4:37 ` Christopher Li
2017-07-06 19:19 ` [PATCH 3/5] avoid crash in rewrite_branch() Luc Van Oostenryck
2017-07-19 22:21 ` Luc Van Oostenryck
2017-07-06 19:19 ` [PATCH 4/5] avoid some crashes in add_dominators() Luc Van Oostenryck
2017-07-19 22:22 ` Luc Van Oostenryck
2017-07-06 19:19 ` Luc Van Oostenryck [this message]
2017-07-19 22:23 ` [PATCH 5/5] avoid crash with sym->bb_target == NULL Luc Van Oostenryck
2017-07-20 10:57 ` Christopher Li
2017-07-29 12:30 ` Luc Van Oostenryck
2017-07-29 12:49 ` Christopher Li
2017-07-06 19:50 ` [PATCH 0/5] fixes for rare crashes Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706191950.81268-6-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).