From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luc Van Oostenryck Subject: Re: [PATCH 1/5] do not corrupt ptrlist while killing unreachable BBs Date: Fri, 7 Jul 2017 08:10:17 +0200 Message-ID: <20170707061016.gcbmwrp7zbhlhbpv@ltop.local> References: <20170706191950.81268-1-luc.vanoostenryck@gmail.com> <20170706191950.81268-2-luc.vanoostenryck@gmail.com> <20170707054459.pkhqnmrz7yt3sppc@ltop.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-wr0-f170.google.com ([209.85.128.170]:34912 "EHLO mail-wr0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbdGGGKT (ORCPT ); Fri, 7 Jul 2017 02:10:19 -0400 Received: by mail-wr0-f170.google.com with SMTP id k67so31606890wrc.2 for ; Thu, 06 Jul 2017 23:10:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: Christopher Li Cc: Linux-Sparse On Thu, Jul 06, 2017 at 11:02:24PM -0700, Christopher Li wrote: > On Thu, Jul 6, 2017 at 10:44 PM, Luc Van Oostenryck > wrote: > > Mmmm ... > > > > I really don't like this kind of solution. > > The ptrlist is already fragile and now it would contains > > yet another field that need to be taken care of *and* stay > > coherent with other users. I doubt this will help to reduce bugs. > > You totally miss the point. This patch is not a final solution. > I am not suggesting submit this patch as it is. > > It is mean to expose existing bugs. Ah, OK. > Go try this patch with a "make check". It has over one hundreds fails. I'll do, later (just wakeup here). > Those are real bugs. The current big offender is remove_usage() inside > of the kill_use_list(). It might relate to your code as well. Can you help me > take a look at the offender? Yes, of course I'll help with this. And yes, I added a bunch of these remove_use() with the recursive call to kill_instruction() which I never liked much but solved a bunch of things. -- Luc