From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Christopher Li <sparse@chrisli.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH 23/34] ptrlist: use the iterator API for DO_DELETE_CURRENT()
Date: Fri, 7 Jul 2017 15:39:51 +0200 [thread overview]
Message-ID: <20170707134002.49500-24-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20170707134002.49500-1-luc.vanoostenryck@gmail.com>
---
ptrlist.h | 26 ++++++++++++++++----------
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/ptrlist.h b/ptrlist.h
index 26697c62f..c27a68f38 100644
--- a/ptrlist.h
+++ b/ptrlist.h
@@ -220,16 +220,22 @@ extern void split_ptr_list_head(struct ptr_list *);
#define INSERT_CURRENT(new, ptr) \
DO_INSERT_CURRENT(new, ptr, __cur##ptr)
-#define DO_DELETE_CURRENT(ptr, __cur) do { \
- void **__this = __cur.l->list + __cur.n; \
- void **__last = __cur.l->list + __cur.l->nr - 1; \
- while (__this < __last) { \
- __this[0] = __this[1]; \
- __this++; \
- } \
- *__this = (void *)0xf0f0f0f0; \
- __cur.l->nr--; __cur.n--; \
-} while (0)
+static inline void ptr_cur_delete(struct ptr_cur *cur, void *ptr)
+{
+ void **this = cur->l->list + cur->n;
+ void **last = cur->l->list + cur->l->nr - 1;
+
+ while (this < last) {
+ this[0] = this[1];
+ this++;
+ }
+ *this = (void *)0xf0f0f0f0;
+ cur->l->nr--;
+ cur->n--;
+}
+
+#define DO_DELETE_CURRENT(ptr, __cur) \
+ ptr_cur_delete(&__cur, ptr)
#define DELETE_CURRENT_PTR(ptr) \
DO_DELETE_CURRENT(ptr, __cur##ptr)
--
2.13.0
next prev parent reply other threads:[~2017-07-07 13:40 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 13:39 [RFC 00/34] ptrlist rework with iterator Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 01/34] ptrlist: simplify DO_FOR_EACH/DO_END_FOR_EACH Luc Van Oostenryck
2017-07-08 15:31 ` Christopher Li
2017-07-07 13:39 ` [PATCH 02/34] ptrlist: simplify DO_FOR_EACH_REVERSE/ Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 03/34] ptrlist: simplify DO_NEXT link walking Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 04/34] ptrlist: add helper __PTR_STRIP_TAG() Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 05/34] ptrlist: introduce the ptr_list iterator structure Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 06/34] ptrlist: add ptr_cur_entry() to get iterator's current entry Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 07/34] ptrlist: add forward iterator Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 08/34] ptrlist: let first_ptr_list() use the iterator API Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 09/34] ptrlist: add backward iterator Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 10/34] ptrlist: let lastst_ptr_list() use the iterator API Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 11/34] ptrlist: mechanically replace head-list-nr triplets by an iterator struct Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 12/34] ptrlist: simplify initialization of DO_REVERSE()'s cursor Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 13/34] ptrlist: abstract away iterator initialization Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 14/34] ptrlist: CUR_ENTRY/CUR_ENTRY_NOTAG Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 15/34] ptrlist: use iterator API for PREPARE/NEXT_PTR_LIST() Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 16/34] ptrlist: use iterator API for RESET_PTR_LIST() Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 17/34] ptrlist: use iterator for FOR_EACH_PTR() Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 18/34] ptrlist: use iterator for FOR_EACH_PTR_REVERSE() Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 19/34] ptrlist: remove unneeded DO_INIT() Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 20/34] ptrlist: use the iterator API for DO_INSERT_CURRENT() Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 21/34] ptrlist: extract ptr_cur_insert from ptrlist.h Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 22/34] ptrlist: simplify ptr_cur_insert() Luc Van Oostenryck
2017-07-07 13:39 ` Luc Van Oostenryck [this message]
2017-07-07 13:39 ` [PATCH 24/34] ptrlist: extract prt_cur_delete() from ptrlist.h Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 25/34] ptrlist: let delete_ptr_list() use the iterator API Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 26/34] ptrlist: let replace_ptr_list_entry() " Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 27/34] ptrlist: let concat_ptr_list() " Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 28/34] ptrlist: let undo_ptr_list_last() " Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 29/34] ptrlist: let delete_ptr_list_last() " Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 30/34] ptrlist: simplify common case for __add_ptr_list() Luc Van Oostenryck
2017-07-07 13:39 ` [PATCH 31/34] ptrlist: explicitely tagged Luc Van Oostenryck
2017-07-07 13:40 ` [PATCH 32/34] ptrlist: tag/notag common case Luc Van Oostenryck
2017-07-07 13:40 ` [PATCH 33/34] ptrlist: drop the now unneeded _NOTAG versions Luc Van Oostenryck
2017-07-07 13:40 ` [PATCH 34/34] ptrlist: addr vs entry Luc Van Oostenryck
2017-07-07 13:51 ` [RFC 00/34] ptrlist rework with iterator Luc Van Oostenryck
2017-07-08 15:13 ` Christopher Li
2017-07-09 6:50 ` Luc Van Oostenryck
2017-07-09 8:25 ` Christopher Li
2017-07-09 9:52 ` Luc Van Oostenryck
2017-07-09 10:34 ` Dibyendu Majumdar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170707134002.49500-24-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).