From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Christopher Li <sparse@chrisli.org>
Cc: linux-sparse@vger.kernel.org,
Michael Stefaniuc <mstefani@mykolab.com>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH v3 4/7] fix crash when ep->active is NULL
Date: Mon, 31 Jul 2017 22:36:21 +0200 [thread overview]
Message-ID: <20170731203624.58971-5-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20170731203624.58971-1-luc.vanoostenryck@gmail.com>
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
linearize.c | 9 +++++++--
validation/crash-ep-active.c | 12 ++++++++++++
2 files changed, 19 insertions(+), 2 deletions(-)
create mode 100644 validation/crash-ep-active.c
diff --git a/linearize.c b/linearize.c
index a36720779..12209492b 100644
--- a/linearize.c
+++ b/linearize.c
@@ -820,10 +820,15 @@ static pseudo_t argument_pseudo(struct entrypoint *ep, int nr)
pseudo_t alloc_phi(struct basic_block *source, pseudo_t pseudo, int size)
{
- struct instruction *insn = alloc_instruction(OP_PHISOURCE, size);
- pseudo_t phi = __alloc_pseudo(0);
+ struct instruction *insn;
+ pseudo_t phi;
static int nr = 0;
+ if (!source)
+ return VOID;
+
+ insn = alloc_instruction(OP_PHISOURCE, size);
+ phi = __alloc_pseudo(0);
phi->type = PSEUDO_PHI;
phi->nr = ++nr;
phi->def = insn;
diff --git a/validation/crash-ep-active.c b/validation/crash-ep-active.c
new file mode 100644
index 000000000..6945f320b
--- /dev/null
+++ b/validation/crash-ep-active.c
@@ -0,0 +1,12 @@
+int a(int b)
+{
+ return 0( && b;
+}
+
+/*
+ * check-name: crash ep->active
+ * check-command: test-linearize $file
+ *
+ * check-error-ignore
+ * check-output-ignore
+ */
--
2.13.2
next prev parent reply other threads:[~2017-07-31 20:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 20:36 [PATCH v3 0/7] fixes for rare issues Luc Van Oostenryck
2017-07-31 20:36 ` [PATCH v3 1/7] fix ptrlist corruption while killing unreachable BBs Luc Van Oostenryck
2017-07-31 21:41 ` Christopher Li
2017-07-31 22:10 ` Luc Van Oostenryck
2017-07-31 20:36 ` [PATCH v3 2/7] fix infinite simplification loops Luc Van Oostenryck
2017-07-31 20:36 ` [PATCH v3 3/7] fix BB dependencies on phi-nodes Luc Van Oostenryck
2017-07-31 20:36 ` Luc Van Oostenryck [this message]
2017-07-31 20:36 ` [PATCH v3 5/7] fix crash in rewrite_branch() Luc Van Oostenryck
2017-07-31 20:36 ` [PATCH v3 6/7] fix some crashes in add_dominators() Luc Van Oostenryck
2017-07-31 20:36 ` [PATCH v3 7/7] fix crash with sym->bb_target == NULL Luc Van Oostenryck
2017-07-31 21:01 ` [PATCH v3 0/7] fixes for rare issues Christopher Li
2017-07-31 21:54 ` Luc Van Oostenryck
2017-07-31 22:34 ` Luc Van Oostenryck
2017-07-31 22:42 ` Luc Van Oostenryck
2017-08-01 20:46 ` Luc Van Oostenryck
2017-08-01 21:49 ` Christopher Li
2017-08-01 22:10 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170731203624.58971-5-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=mstefani@mykolab.com \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).