Linux SPARSE checker discussions
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <uwe@kleine-koenig.org>
To: linux-sparse@vger.kernel.org
Subject: [PATCH] compile-i386: Use SPARSE_VERSION instead of __DATE__
Date: Fri, 22 Sep 2017 10:14:10 +0200	[thread overview]
Message-ID: <20170922081410.29162-1-uwe@kleine-koenig.org> (raw)

The compile date isn't very informative for a tool, the version is what really
matters. Additionally using __DATE__ makes the build unreprodicible.

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
---
 compile-i386.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/compile-i386.c b/compile-i386.c
index e4d3f27dd8a9..1cedcbda73d8 100644
--- a/compile-i386.c
+++ b/compile-i386.c
@@ -57,6 +57,7 @@
 #include "target.h"
 #include "compile.h"
 #include "bitmap.h"
+#include "version.h"
 
 struct textbuf {
 	unsigned int	len;	/* does NOT include terminating null */
@@ -691,7 +692,7 @@ void emit_unit_begin(const char *basename)
 void emit_unit_end(void)
 {
 	textbuf_emit(&unit_post_text);
-	printf("\t.ident\t\"sparse silly x86 backend (built %s)\"\n", __DATE__);
+	printf("\t.ident\t\"sparse silly x86 backend (version %s)\"\n", SPARSE_VERSION);
 }
 
 /* conditionally switch sections */
-- 
2.14.1


             reply	other threads:[~2017-09-22  8:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-22  8:14 Uwe Kleine-König [this message]
2017-10-02 19:47 ` [PATCH] compile-i386: Use SPARSE_VERSION instead of __DATE__ Luc Van Oostenryck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170922081410.29162-1-uwe@kleine-koenig.org \
    --to=uwe@kleine-koenig.org \
    --cc=linux-sparse@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox