From: Jacob Keller <jacob.e.keller@intel.com>
To: linux-sparse@vger.kernel.org
Cc: Jacob Keller <jacob.e.keller@intel.com>
Subject: [PATCH] sparse: document that -Wbitwise is default
Date: Tue, 17 Oct 2017 16:31:36 -0700 [thread overview]
Message-ID: <20171017233136.24533-1-jacob.e.keller@intel.com> (raw)
In commit commit 02a886bfa3d9 ("Introduce keyword driven
attribute parsing", 2007-03-08) the -Wbitwise keyword was broken and did
not actually work. Instead, bitwise checks were always enabled.
This was fixed by commit commit 0dfda0d1f0fe ("make -Wbitwise
operational again", 2017-02-18) which allowed -Wbitwise and -Wno-bitwise
to work as expected.
However, since -Wbitwise was enabled for so long, that commit changed
the default of -Wbitwise to be enabled, rather than the documented
"disabled".
Fix the documentation to match, and explain that -Wbitwise is enabled by
default and must be disabled.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
sparse.1 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sparse.1 b/sparse.1
index fd4527aa5c95..bdfe14902ba6 100644
--- a/sparse.1
+++ b/sparse.1
@@ -67,8 +67,8 @@ kind of like "NULL" for pointers). So "gfp_t" or the "safe endianness"
types would be __bitwise: you can only operate on them by doing
specific operations that know about *that* particular type.
-Generally, you want bitwise if you are looking for type safety. Sparse
-does not issue these warnings by default.
+Sparse issues these warnings by default. To turn them off, use
+\fB\-Wno\-bitwise\fR.
.
.TP
.B \-Wcast\-to\-as
--
2.14.1.436.g33e61a4f0239
next reply other threads:[~2017-10-17 23:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 23:31 Jacob Keller [this message]
2017-10-18 15:35 ` [PATCH] sparse: document that -Wbitwise is default Luc Van Oostenryck
2017-10-18 19:29 ` Christopher Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017233136.24533-1-jacob.e.keller@intel.com \
--to=jacob.e.keller@intel.com \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).