Re: [PATCH 01/36] build: make PREFIX overwritable from the environment

[Josh Triplett <josh@joshtriplett.org>]

On Sun, Nov 05, 2017 at 05:25:09PM +0100, Luc Van Oostenryck wrote:
> From: Uwe Kleine-König <uwe@kleine-koenig.org>
> 
> This way I can just use
> 
> 	env PREFIX=/usr make install
> 
> on the command line to install sparse into the system.

You can already use "make PREFIX=/usr install" to do this, which seems
far more conventional, and seems less error-prone (e.g. it won't pick up
something random from the environment, only something intentionally put
on the command line).

Any particular reason to do this?

>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index d03417641..e011df3cc 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -54,7 +54,7 @@ BASIC_CFLAGS += -Wp,-MD,$(@D)/.$(@F).d
>  endif
>  
>  DESTDIR=
> -PREFIX=$(HOME)
> +PREFIX ?= $(HOME)
>  BINDIR=$(PREFIX)/bin
>  LIBDIR=$(PREFIX)/lib
>  MANDIR=$(PREFIX)/share/man
> -- 
> 2.14.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html