From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luc Van Oostenryck Subject: Re: [PATCH 21/36] build: no need to clean *.so and SLIB_FILE Date: Sun, 5 Nov 2017 21:06:31 +0100 Message-ID: <20171105200629.hkffk2l5zsev24mm@ltop.local> References: <20171105162448.72907-1-luc.vanoostenryck@gmail.com> <20171105162544.72960-21-luc.vanoostenryck@gmail.com> <20171105174807.b4p6hmthwammarbv@s> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:56476 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750731AbdKEUGe (ORCPT ); Sun, 5 Nov 2017 15:06:34 -0500 Received: by mail-wm0-f65.google.com with SMTP id z3so10368562wme.5 for ; Sun, 05 Nov 2017 12:06:34 -0800 (PST) Content-Disposition: inline In-Reply-To: <20171105174807.b4p6hmthwammarbv@s> Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: Josh Triplett Cc: linux-sparse@vger.kernel.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= On Sun, Nov 05, 2017 at 09:48:07AM -0800, Josh Triplett wrote: > On Sun, Nov 05, 2017 at 05:25:29PM +0100, Luc Van Oostenryck wrote: > > Signed-off-by: Luc Van Oostenryck > > --- > > Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Makefile b/Makefile > > index a8578c305..23c334132 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -207,7 +207,7 @@ version.h: FORCE > > > > > > clean: clean-check > > - rm -f *.[oa] .*.d *.so $(PROGRAMS) $(SLIB_FILE) version.h > > + rm -f *.[oa] .*.d $(PROGRAMS) $(SLIB_FILE) version.h > > You didn't remove SLIB_FILE here. And also, this should get squashed > into the patch that stops building these. I know, this patch only remove the '*.so' which was redundant with $(SLIB_FILE). This was before I decided to remove everything related to shared lib. And yes, once shared are removed, it's simpler to remove everything at the same time. I'll do that in next version. Thanks for the review, -- Luc