* [PATCH] graph: do not scan removed instructions
@ 2017-11-07 10:54 Luc Van Oostenryck
2017-11-07 18:54 ` Christopher Li
0 siblings, 1 reply; 3+ messages in thread
From: Luc Van Oostenryck @ 2017-11-07 10:54 UTC (permalink / raw)
To: linux-sparse; +Cc: Josh Triplett, Luc Van Oostenryck
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
graph.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/graph.c b/graph.c
index 8cbc22027..c9af9a580 100644
--- a/graph.c
+++ b/graph.c
@@ -130,6 +130,8 @@ static void graph_calls(struct entrypoint *ep, int internal)
continue;
FOR_EACH_PTR(bb->insns, insn) {
+ if (!insn->bb)
+ continue;
if (insn->opcode == OP_CALL &&
internal == !(insn->func->sym->ctype.modifiers & MOD_EXTERN)) {
--
2.14.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] graph: do not scan removed instructions
2017-11-07 10:54 [PATCH] graph: do not scan removed instructions Luc Van Oostenryck
@ 2017-11-07 18:54 ` Christopher Li
2017-11-08 8:17 ` Luc Van Oostenryck
0 siblings, 1 reply; 3+ messages in thread
From: Christopher Li @ 2017-11-07 18:54 UTC (permalink / raw)
To: Luc Van Oostenryck; +Cc: Linux-Sparse, Josh Triplett
On Tue, Nov 7, 2017 at 6:54 PM, Luc Van Oostenryck
<luc.vanoostenryck@gmail.com> wrote:
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
> graph.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/graph.c b/graph.c
> index 8cbc22027..c9af9a580 100644
> --- a/graph.c
> +++ b/graph.c
> @@ -130,6 +130,8 @@ static void graph_calls(struct entrypoint *ep, int internal)
> continue;
>
> FOR_EACH_PTR(bb->insns, insn) {
> + if (!insn->bb)
> + continue;
Looks good to me.
Chris
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] graph: do not scan removed instructions
2017-11-07 18:54 ` Christopher Li
@ 2017-11-08 8:17 ` Luc Van Oostenryck
0 siblings, 0 replies; 3+ messages in thread
From: Luc Van Oostenryck @ 2017-11-08 8:17 UTC (permalink / raw)
To: Christopher Li; +Cc: Linux-Sparse, Josh Triplett
On Wed, Nov 08, 2017 at 02:54:17AM +0800, Christopher Li wrote:
> On Tue, Nov 7, 2017 at 6:54 PM, Luc Van Oostenryck
> <luc.vanoostenryck@gmail.com> wrote:
> > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> > ---
> > graph.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/graph.c b/graph.c
> > index 8cbc22027..c9af9a580 100644
> > --- a/graph.c
> > +++ b/graph.c
> > @@ -130,6 +130,8 @@ static void graph_calls(struct entrypoint *ep, int internal)
> > continue;
> >
> > FOR_EACH_PTR(bb->insns, insn) {
> > + if (!insn->bb)
> > + continue;
>
> Looks good to me.
Thank you for the review.
Thank you for the very fast review.
-- Luc
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-08 8:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-07 10:54 [PATCH] graph: do not scan removed instructions Luc Van Oostenryck
2017-11-07 18:54 ` Christopher Li
2017-11-08 8:17 ` Luc Van Oostenryck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).