From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Christopher Li <sparse@chrisli.org>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>,
Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCH] graph: do not scan removed instructions
Date: Wed, 8 Nov 2017 09:17:58 +0100 [thread overview]
Message-ID: <20171108081756.ulvrn2q4ohjni4ks@ltop.local> (raw)
In-Reply-To: <CANeU7QkG8NqyYWy6OmmDjaXXeS1iuZxrnbvG2CADd6qGpjL2Ow@mail.gmail.com>
On Wed, Nov 08, 2017 at 02:54:17AM +0800, Christopher Li wrote:
> On Tue, Nov 7, 2017 at 6:54 PM, Luc Van Oostenryck
> <luc.vanoostenryck@gmail.com> wrote:
> > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> > ---
> > graph.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/graph.c b/graph.c
> > index 8cbc22027..c9af9a580 100644
> > --- a/graph.c
> > +++ b/graph.c
> > @@ -130,6 +130,8 @@ static void graph_calls(struct entrypoint *ep, int internal)
> > continue;
> >
> > FOR_EACH_PTR(bb->insns, insn) {
> > + if (!insn->bb)
> > + continue;
>
> Looks good to me.
Thank you for the review.
Thank you for the very fast review.
-- Luc
prev parent reply other threads:[~2017-11-08 8:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 10:54 [PATCH] graph: do not scan removed instructions Luc Van Oostenryck
2017-11-07 18:54 ` Christopher Li
2017-11-08 8:17 ` Luc Van Oostenryck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108081756.ulvrn2q4ohjni4ks@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).