From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-sparse@vger.kernel.org, Christopher Li <sparse@chrisli.org>
Subject: Re: [PATCH v2] add __builtin functions for isinf_sign, isfinite and isnan
Date: Fri, 17 Nov 2017 09:13:49 +0100 [thread overview]
Message-ID: <20171117081348.5cdzuctwi6i3ltu6@ltop.local> (raw)
In-Reply-To: <20171116230817.10011-1-logang@deltatee.com>
On Thu, Nov 16, 2017 at 04:08:17PM -0700, Logan Gunthorpe wrote:
> These bultins are defined by in gcc since 4.4. They are also now
> used by the isinf, isfinite and isnan macros. So using them with a
> newer gcc causes 'undefined identifier' errors.
>
> Add the builtin definitions and some validation checks for these
> functions.
>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Acked-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
>
> Changes since v1:
> * Remove math.h dependancy from validation tests. As a consequnce
> we don't test that the math functions work. (Per a request from
> Christopher.)
It would only have tested if your <math.h> doesn't have errors.
-- Luc
next prev parent reply other threads:[~2017-11-17 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 23:08 [PATCH v2] add __builtin functions for isinf_sign, isfinite and isnan Logan Gunthorpe
2017-11-17 0:02 ` Christopher Li
2017-11-17 1:04 ` Logan Gunthorpe
2017-11-17 8:13 ` Luc Van Oostenryck [this message]
2017-11-17 23:28 ` Luc Van Oostenryck
2017-11-17 23:39 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171117081348.5cdzuctwi6i3ltu6@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox