From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH 1/3] add testcases for ignored type attributes
Date: Mon, 22 Jan 2018 07:36:03 +0100 [thread overview]
Message-ID: <20180122063605.97737-2-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20180122063605.97737-1-luc.vanoostenryck@gmail.com>
Currently, sparse doesn't correctly take in account
type attributes.
Add some test cases for those.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
validation/type-attribute-align.c | 20 ++++++++++++++++++++
validation/type-attribute-as.c | 34 ++++++++++++++++++++++++++++++++++
validation/type-attribute-mod.c | 22 ++++++++++++++++++++++
3 files changed, 76 insertions(+)
create mode 100644 validation/type-attribute-align.c
create mode 100644 validation/type-attribute-as.c
create mode 100644 validation/type-attribute-mod.c
diff --git a/validation/type-attribute-align.c b/validation/type-attribute-align.c
new file mode 100644
index 000000000..d56769c44
--- /dev/null
+++ b/validation/type-attribute-align.c
@@ -0,0 +1,20 @@
+#define __aligned(N) __attribute__((aligned(N)))
+#define alignof(X) __alignof__(X)
+
+struct s {
+ short a, b, c;
+} __aligned(2*sizeof(short));
+
+static int fs(void) { return sizeof(struct s); }
+static int fa(void) { return alignof(struct s); }
+
+void main(void)
+{
+ _Static_assert( sizeof(struct s) == 4 * sizeof(short), "size");
+ _Static_assert(alignof(struct s) == 2 * sizeof(short), "alignment");
+}
+
+/*
+ * check-name: type-attribute-align
+ * check-known-to-fail
+ */
diff --git a/validation/type-attribute-as.c b/validation/type-attribute-as.c
new file mode 100644
index 000000000..375ad4c76
--- /dev/null
+++ b/validation/type-attribute-as.c
@@ -0,0 +1,34 @@
+#define __user __attribute__((address_space(1)))
+
+struct s {
+ int i;
+} __user;
+
+
+extern void use0(void *);
+extern void use1(void __user *);
+
+void main(void)
+{
+ struct s s;
+ int i;
+
+ use0(&s); // KO
+ use0(&i); // OK
+ use1(&s); // OK
+ use1(&i); // KO
+}
+
+/*
+ * check-name: type-attribute-as
+ * check-known-to-fail
+ *
+ * check-error-start
+type-attribute-as.c:16:15: warning: incorrect type in argument 1 (different address spaces)
+type-attribute-as.c:16:15: expected void *<noident>
+type-attribute-as.c:16:15: got struct s <asn:1>*<noident>
+type-attribute-as.c:19:15: warning: incorrect type in argument 1 (different address spaces)
+type-attribute-as.c:19:15: expected void <asn:1>*<noident>
+type-attribute-as.c:19:15: got int *<noident>
+ * check-error-end
+ */
diff --git a/validation/type-attribute-mod.c b/validation/type-attribute-mod.c
new file mode 100644
index 000000000..0e7b166a4
--- /dev/null
+++ b/validation/type-attribute-mod.c
@@ -0,0 +1,22 @@
+#define __noderef __attribute__((noderef))
+
+struct s {
+ int i;
+} __noderef;
+
+
+void main(void)
+{
+ struct s s;
+
+ s.i = 0;
+}
+
+/*
+ * check-name: type-attribute-mod
+ * check-known-to-fail
+ *
+ * check-error-start
+type-attribute-mod.c:12:9: warning: dereference of noderef expression
+ * check-error-end
+ */
--
2.16.0
next prev parent reply other threads:[~2018-01-22 6:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 6:36 [PATCH 0/3] fix ignored type attributes Luc Van Oostenryck
2018-01-22 6:36 ` Luc Van Oostenryck [this message]
2018-01-22 6:36 ` [PATCH 2/3] move up apply_ctype()'s declaration Luc Van Oostenryck
2018-01-22 6:36 ` [PATCH 3/3] fix: do not ignore struct/union/enum type attributes Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122063605.97737-2-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).