linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>,
	Christopher Li <sparse@chrisli.org>
Subject: Re: [PATCH] test-suite: handle format with filename.c not existing
Date: Wed, 24 Jan 2018 09:28:15 +0100	[thread overview]
Message-ID: <20180124082814.a36sur5e7cusrleb@ltop.local> (raw)
In-Reply-To: <5d19aa93-b421-eb1f-3a4c-92fc9476747a@infradead.org>

On Mon, Jan 22, 2018 at 11:05:09AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> In error(), quiet is undefined when the command:
>   $ ./test-suite format filename1.c foobar1
> 
> is used and filename1.c does not exist. This causes a shell script error:
>   ./test-suite: line 147: [: : integer expression expected
> 
> because $quiet is undefined in
>   [ "$quiet" -ne 1 ] && echo "error: $1"
> so the error message is lost.
> 
> Just initialize quiet before any command line parsing.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

cfr: https://marc.info/?l=linux-sparse&m=151273892009415

-- Luc

  parent reply	other threads:[~2018-01-24  8:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22 19:05 [PATCH] test-suite: handle format with filename.c not existing Randy Dunlap
2018-01-23 11:22 ` Christopher Li
2018-01-23 18:20   ` Randy Dunlap
2018-01-23 23:38     ` Christopher Li
2018-01-24  1:38       ` Randy Dunlap
2018-01-24 19:19         ` Christopher Li
2018-01-24 19:26           ` Randy Dunlap
2018-01-24  8:15     ` Luc Van Oostenryck
2018-01-24  8:28 ` Luc Van Oostenryck [this message]
2018-01-24 17:48   ` Randy Dunlap
2018-01-24 19:13     ` Christopher Li
2018-01-24 19:19     ` Luc Van Oostenryck
2018-01-24 19:25       ` Luc Van Oostenryck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180124082814.a36sur5e7cusrleb@ltop.local \
    --to=luc.vanoostenryck@gmail.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sparse@chrisli.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).