From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Linux-Sparse <linux-sparse@vger.kernel.org>,
Christopher Li <sparse@chrisli.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] sparse: ignore indirect_branch attribute
Date: Tue, 13 Feb 2018 23:12:47 +0100 [thread overview]
Message-ID: <20180213221245.2ylhdtqdf4c5qmog@ltop.local> (raw)
In-Reply-To: <c97d360f-a0d2-8c0d-b951-e064843ff4d8@infradead.org>
On Tue, Feb 13, 2018 at 01:52:54PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Teach sparse about the "indirect_branch" attribute as used in
> Linux kernel:
> #define __noretpoline __attribute__((indirect_branch("keep")))
> and tell sparse to ignore it.
>
> This eliminates over 148K warnings (which also cause the
> 0day bot to send error reports uselessly).
Sigh.
I think that these unknown attribute warnings are useless
in general and even more so for the kernel. The kernel should
have "-Wno-unknown-attribute" in its CHECKFLAGS.
> Or does sparse need to do something with it?
No, it's the only thing needed. Thanks.
I've applied it in my dev tree and will push it in a few
days to the stable tree where I collect all pending changes:
git://github.com/lucvoo/sparse.git
-- Luc
next prev parent reply other threads:[~2018-02-13 22:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 21:52 [PATCH] sparse: ignore indirect_branch attribute Randy Dunlap
2018-02-13 22:12 ` Luc Van Oostenryck [this message]
2018-02-15 20:42 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213221245.2ylhdtqdf4c5qmog@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sparse@chrisli.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox