linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrey Konovalov <andreyknvl@google.com>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Alexander Potapenko <glider@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Christoph Lameter <cl@linux.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Dave Martin <dave.martin@arm.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"Eric W . Biederman" <ebiederm@xmission.com>,
	Ingo Molnar <mingo@kernel.org>,
	Paul Lawrence <paullawrence@google.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Arnd Bergmann <arnd@arndb.de>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kate Stewart <kst>
Subject: Re: [PATCH v6 00/18] khwasan: kernel hardware assisted address sanitizer
Date: Thu, 6 Sep 2018 11:05:43 +0100	[thread overview]
Message-ID: <20180906100543.GI3592@arm.com> (raw)
In-Reply-To: <20180905141032.b1ddaab53d1b2b3bada95415@linux-foundation.org>

On Wed, Sep 05, 2018 at 02:10:32PM -0700, Andrew Morton wrote:
> On Wed, 29 Aug 2018 13:35:04 +0200 Andrey Konovalov <andreyknvl@google.com> wrote:
> 
> > This patchset adds a new mode to KASAN [1], which is called KHWASAN
> > (Kernel HardWare assisted Address SANitizer).
> 
> We're at v6 and there are no reviewed-by's or acked-by's to be seen. 
> Is that a fair commentary on what has been happening, or have people
> been remiss in sending and gathering such things?

I still have concerns about the consequences of merging this as anything
other than a debug option [1]. Unfortunately, merging it as a debug option
defeats the whole point, so I think we need to spend more effort on developing
tools that can help us to find and fix the subtle bugs which will arise from
enabling tagged pointers in the kernel.

Will

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-August/596077.html

  parent reply	other threads:[~2018-09-06 10:05 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1535462971.git.andreyknvl@google.com>
2018-09-05 21:10 ` [PATCH v6 00/18] khwasan: kernel hardware assisted address sanitizer Andrew Morton
2018-09-05 21:55   ` Nick Desaulniers
2018-09-06 10:05   ` Will Deacon [this message]
2018-09-06 11:06     ` Andrey Konovalov
2018-09-06 16:39       ` Nick Desaulniers
2018-09-14 15:28       ` Will Deacon
2018-09-19 18:53         ` Andrey Konovalov
     [not found] ` <db103bdc2109396af0c6007f1669ebbbb63b872b.1535462971.git.andreyknvl@google.com>
     [not found]   ` <3f2dee71-1615-4a34-d611-3ccaf407551e@virtuozzo.com>
2018-09-11 16:10     ` [PATCH v6 16/18] khwasan, mm, arm64: tag non slab memory allocated via pagealloc Andrey Konovalov
     [not found] ` <868c9168481ff5103034ac1e37b830d28ed5f4ee.1535462971.git.andreyknvl@google.com>
2018-09-12 14:47   ` [PATCH v6 03/18] khwasan: add CONFIG_KASAN_GENERIC and CONFIG_KASAN_HW Dmitry Vyukov
2018-09-12 14:51     ` Dmitry Vyukov
2018-09-17 18:42     ` Andrey Konovalov
     [not found] ` <b4ba65afa55f2fdfd2856fb03c5aba99c7a8bdd7.1535462971.git.andreyknvl@google.com>
2018-09-12 14:54   ` [PATCH v6 04/18] khwasan, arm64: adjust shadow size for CONFIG_KASAN_HW Dmitry Vyukov
2018-09-19 17:27     ` Andrey Konovalov
     [not found] ` <6cd298a90d02068969713f2fd440eae21227467b.1535462971.git.andreyknvl@google.com>
2018-09-12 16:21   ` [PATCH v6 07/18] khwasan: add tag related helper functions Dmitry Vyukov
2018-09-17 18:59     ` Andrey Konovalov
2018-09-18 15:45       ` Dmitry Vyukov
     [not found] ` <19d757c2cafc277f0143a8ac34e179061f3487f5.1535462971.git.andreyknvl@google.com>
2018-09-12 16:33   ` [PATCH v6 06/18] khwasan, arm64: untag virt address in __kimg_to_phys and _virt_addr_is_linear Dmitry Vyukov
2018-09-18 17:09     ` Andrey Konovalov
     [not found] ` <95b5beb7ec13b7e998efe84c9a7a5c1fa49a9fe3.1535462971.git.andreyknvl@google.com>
2018-09-12 16:36   ` [PATCH v6 08/18] khwasan: preassign tags to objects with ctors or SLAB_TYPESAFE_BY_RCU Dmitry Vyukov
2018-09-18 16:50     ` Andrey Konovalov
     [not found] ` <f5e73b5ead3355932ad8b5fc96b141c3f5b8c16c.1535462971.git.andreyknvl@google.com>
2018-09-12 17:13   ` [PATCH v6 15/18] khwasan, arm64: add brk handler for inline instrumentation Dmitry Vyukov
2018-09-17 19:12     ` Andrey Konovalov
2018-09-12 17:15   ` Dmitry Vyukov
2018-09-12 17:39     ` Jann Horn
2018-09-13  8:37       ` Dmitry Vyukov
2018-09-13 18:09         ` Nick Desaulniers
2018-09-13 18:23           ` Jann Horn
2018-09-14  5:11           ` Dmitry Vyukov
     [not found] ` <f39cdef4fde40b6d2ef356db3e0126bda0e1e8c7.1535462971.git.andreyknvl@google.com>
2018-09-12 17:50   ` [PATCH v6 13/18] khwasan: add bug reporting routines Dmitry Vyukov
2018-09-18 17:36     ` Andrey Konovalov
     [not found] ` <4267d0903e0fdf9c261b91cf8a2bf0f71047a43c.1535462971.git.andreyknvl@google.com>
2018-09-12 18:30   ` [PATCH v6 14/18] khwasan: add hooks implementation Dmitry Vyukov
2018-09-19 11:54     ` Andrey Konovalov
     [not found] ` <1a3b3030b6ee01931b397583b69f3af94e2a2308.1535462971.git.andreyknvl@google.com>
2018-09-12 18:39   ` [PATCH v6 17/18] khwasan: update kasan documentation Dmitry Vyukov
2018-09-18 18:42     ` Andrey Konovalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180906100543.GI3592@arm.com \
    --to=will.deacon@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@google.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=aryabinin@virtuozzo.com \
    --cc=catalin.marinas@arm.com \
    --cc=cl@linux.com \
    --cc=dave.martin@arm.com \
    --cc=dvyukov@google.com \
    --cc=ebiederm@xmission.com \
    --cc=geert@linux-m68k.org \
    --cc=glider@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=mingo@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=paullawrence@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).