Linux SPARSE checker discussions
 help / color / mirror / Atom feed
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
	joe@perches.com, Kees Cook <keescook@chromium.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-sparse@vger.kernel.org, sparse@chrisli.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: Conflict between sparse and commit cafa0010cd51f ("Raise the minimum required gcc version to 4.6")
Date: Mon, 10 Sep 2018 15:56:05 +0200	[thread overview]
Message-ID: <20180910135604.j2phe7r3k5vs6cik@ltop.local> (raw)
In-Reply-To: <9409138a-dc14-2b12-edc0-cfa0b471da6e@c-s.fr>

On Mon, Sep 10, 2018 at 01:19:07PM +0000, Christophe Leroy wrote:
> 
> 
> On 09/10/2018 11:34 AM, Luc Van Oostenryck wrote:
> > On Mon, Sep 10, 2018 at 09:56:33AM +0000, Christophe Leroy wrote:
> > > 
> > > # export REAL_CC=ppc-linux-gcc
> > > # make CHECK="cgcc -target=ppc -D_CALL_ELF=2 -D__GCC__=5
> > > -D__GCC_MINOR__=4" C=2 arch/powerpc/kernel/process.o
> > > scripts/kconfig/conf  --syncconfig Kconfig
> > > #
> > > # configuration written to .config
> > > #
> > >    UPD     include/config/kernel.release
> > >    UPD     include/generated/utsrelease.h
> > >    CC      kernel/bounds.s
> > >    CC      arch/powerpc/kernel/asm-offsets.s
> > >    CALL    scripts/checksyscalls.sh
> > >    CHECK   scripts/mod/empty.c
> > > Can't exec "/bin/sh": Argument list too long at /usr/local/bin/cgcc line 86.
> > > make[2]: *** [scripts/mod/empty.o] Error 1
> > > make[1]: *** [scripts/mod] Error 2
> > > make: *** [scripts] Error 2
> > 
> > OK. Clearly nobody has ever used it so :(
> > There is an infinite loop because cgcc use the env var CHECK
> > to call sparse while kbuild use CHECK to call cgcc here.
> > 
> > The following seems to work here.
> > $ export REAL_CC=ppc-linux-gcc
> > $ make CHECK="CHECK=sparse cgcc -target=ppc ...
> 
> Not yet ...
> 
> [root@pc16082vm linux-powerpc]# export REAL_CC=ppc-linux-gcc
> [root@pc16082vm linux-powerpc]# make CHECK="CHECK=sparse cgcc
> -target=ppc -D_CALL_ELF=2 -D__GNUC__=5 -D__GNUC_MINOR__=4" C=2
> arch/powerpc/kernel/process.o
>   CALL    scripts/checksyscalls.sh
>   CHECK   scripts/mod/empty.c
> <command-line>:0:0: warning: "__STDC__" redefined
> <built-in>: note: this is the location of the previous definition
> /opt/cldk-1.4.0/lib/gcc/ppc-linux/5.4.0/../../../../ppc-linux/lib/crt1.o:(.rodata+0x4):
> undefined reference to `main'
> collect2: error: ld returned 1 exit status
> make[2]: *** [scripts/mod/empty.o] Error 1
> make[1]: *** [scripts/mod] Error 2
> make: *** [scripts] Error 2

OK. Using cgcc creates more problems that it solves and this file
scripts/mod/empty.c is weird.
Dropping cgcc and simply giving the GCC version to sparse works for
me here (the needed defines are given by arch/powerpc/Makefile) but
for sure I don't have the same environment as you have:
  $ make CHECK="sparse -D__GNUC__=5 -D__GNUC_MINOR__=4" ...

Bonne chance,
-- Luc

  reply	other threads:[~2018-09-10 13:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <81a5fd11-366c-0897-4143-d8d041420a41@c-s.fr>
2018-09-07 14:33 ` Conflict between sparse and commit cafa0010cd51f ("Raise the minimum required gcc version to 4.6") Christophe LEROY
2018-09-07 17:22   ` Nick Desaulniers
2018-09-07 18:13     ` Luc Van Oostenryck
2018-09-07 18:19       ` Nick Desaulniers
2018-09-07 18:37         ` Luc Van Oostenryck
2018-09-10  6:49         ` Christophe LEROY
2018-09-10  9:28           ` Luc Van Oostenryck
2018-09-10  9:56             ` Christophe Leroy
2018-09-10 11:34               ` Luc Van Oostenryck
2018-09-10 13:19                 ` Christophe Leroy
2018-09-10 13:56                   ` Luc Van Oostenryck [this message]
2018-09-10 14:05                     ` Christophe LEROY
2018-09-10 15:15                       ` Luc Van Oostenryck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180910135604.j2phe7r3k5vs6cik@ltop.local \
    --to=luc.vanoostenryck@gmail.com \
    --cc=christophe.leroy@c-s.fr \
    --cc=joe@perches.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=ndesaulniers@google.com \
    --cc=sparse@chrisli.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox