From: Catalin Marinas <catalin.marinas@arm.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Will Deacon <will.deacon@arm.com>,
Christoph Lameter <cl@linux.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mark Rutland <mark.rutland@arm.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Dave Martin <dave.martin@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Ingo Molnar <mingo@kernel.org>,
Paul Lawrence <paullawrence@google.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Arnd Bergmann <arnd@arndb.de>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@l>
Subject: Re: [PATCH v10 12/22] kasan, arm64: fix up fault handling logic
Date: Wed, 7 Nov 2018 18:26:27 +0000 [thread overview]
Message-ID: <20181107182626.GD255021@arrakis.emea.arm.com> (raw)
In-Reply-To: <4891a504adf61c0daf1e83642b6f7519328dfd5f.1541525354.git.andreyknvl@google.com>
On Tue, Nov 06, 2018 at 06:30:27PM +0100, Andrey Konovalov wrote:
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index 7d9571f4ae3d..d9a84d6f3343 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -32,6 +32,7 @@
> #include <linux/perf_event.h>
> #include <linux/preempt.h>
> #include <linux/hugetlb.h>
> +#include <linux/kasan.h>
>
> #include <asm/bug.h>
> #include <asm/cmpxchg.h>
> @@ -141,6 +142,8 @@ void show_pte(unsigned long addr)
> pgd_t *pgdp;
> pgd_t pgd;
>
> + addr = (unsigned long)kasan_reset_tag((void *)addr);
> +
> if (addr < TASK_SIZE) {
> /* TTBR0 */
> mm = current->active_mm;
I think we should clear the tag earlier on in the fault handling code,
before reaching show_pte().
--
Catalin
next prev parent reply other threads:[~2018-11-07 18:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1541525354.git.andreyknvl@google.com>
2018-11-07 14:56 ` [PATCH v10 00/22] kasan: add software tag-based mode for arm64 Andrey Konovalov
2018-11-07 14:59 ` Will Deacon
2018-11-07 15:11 ` Andrey Konovalov
2018-11-07 15:34 ` Will Deacon
2018-11-07 15:54 ` Andrey Konovalov
2018-11-07 15:56 ` Andrey Konovalov
[not found] ` <86d1b17c755d8bfd6e44e6869a16f4a409e7bd06.1541525354.git.andreyknvl@google.com>
2018-11-07 16:54 ` [PATCH v10 06/22] kasan, arm64: adjust shadow size for tag-based mode Mark Rutland
2018-11-12 17:50 ` Andrey Konovalov
[not found] ` <ea8f0391d7befab4afec34d2a009028cd9e0f326.1541525354.git.andreyknvl@google.com>
2018-11-07 17:04 ` [PATCH v10 05/22] kasan: add CONFIG_KASAN_GENERIC and CONFIG_KASAN_SW_TAGS Mark Rutland
2018-11-12 18:21 ` Andrey Konovalov
[not found] ` <9405f32797b52616cd0746bcea37df94e8e4256a.1541525354.git.andreyknvl@google.com>
2018-11-07 17:08 ` [PATCH v10 07/22] kasan: initialize shadow to 0xff for tag-based mode Mark Rutland
2018-11-13 14:13 ` Andrey Konovalov
[not found] ` <b8c56d36b79eecf0c331a0a7a2df12632aefccc9.1541525354.git.andreyknvl@google.com>
2018-11-07 17:23 ` [PATCH v10 09/22] kasan: add tag related helper functions Mark Rutland
2018-11-14 19:19 ` Andrey Konovalov
[not found] ` <b2aa056b65b8f1a410379bf2f6ef439d5d99e8eb.1541525354.git.andreyknvl@google.com>
2018-11-07 16:52 ` [PATCH v10 08/22] kasan, arm64: untag address in __kimg_to_phys and _virt_addr_is_linear Mark Rutland
2018-11-14 19:23 ` Andrey Konovalov
2018-11-15 13:43 ` Andrey Konovalov
2018-11-07 18:10 ` Catalin Marinas
2018-11-14 19:52 ` Andrey Konovalov
[not found] ` <4891a504adf61c0daf1e83642b6f7519328dfd5f.1541525354.git.andreyknvl@google.com>
2018-11-07 18:26 ` Catalin Marinas [this message]
2018-11-08 12:22 ` [PATCH v10 12/22] kasan, arm64: fix up fault handling logic Mark Rutland
2018-11-13 15:01 ` Andrey Konovalov
2018-11-13 22:07 ` Mark Rutland
2018-11-14 20:06 ` Andrey Konovalov
2018-11-14 20:17 ` Mark Rutland
2018-11-15 13:33 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107182626.GD255021@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=cl@linux.com \
--cc=dave.martin@arm.com \
--cc=dvyukov@google.com \
--cc=ebiederm@xmission.com \
--cc=geert@linux-m68k.org \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kstewart@l \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=ndesaulniers@google.com \
--cc=paullawrence@google.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).