From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH] locking/refcount: add sparse annotations to dec-and-lock functions Date: Tue, 7 Jan 2020 10:29:35 +0100 Message-ID: <20200107092935.GU2844@hirez.programming.kicks-ass.net> References: <20191226152922.2034-1-ebiggers@kernel.org> <20191228114918.GU2827@hirez.programming.kicks-ass.net> <201912301042.FB806E1133@keescook> <20191230191547.GA1501@zzz.localdomain> <201912301131.2C7C51E8C6@keescook> <20191230233814.2fgmsgtnhruhklnu@ltop.local> <20200106154119.GV2810@hirez.programming.kicks-ass.net> <20200106175459.tjuhmdrsusax3s4z@ltop.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200106175459.tjuhmdrsusax3s4z@ltop.local> Sender: linux-kernel-owner@vger.kernel.org To: Luc Van Oostenryck Cc: Kees Cook , Eric Biggers , linux-kernel@vger.kernel.org, Ingo Molnar , Will Deacon , Elena Reshetova , Thomas Gleixner , Anna-Maria Gleixner , Sebastian Andrzej Siewior , linux-sparse@vger.kernel.org List-Id: linux-sparse@vger.kernel.org On Mon, Jan 06, 2020 at 06:54:59PM +0100, Luc Van Oostenryck wrote: > On Mon, Jan 06, 2020 at 04:41:19PM +0100, Peter Zijlstra wrote: > > extern bool spin_trylock(spinlock_t *lock) __attribute__((context(lock, 0, spin_trylock(lock)); > > Well, allowing arbitrary conditions would be hard/impossible but you're > only asking to have the *return value* as condition, right? That looks > as reasonably feasible. Just the return value would cover all the known cases yes. At the time I might have been somewhat over ambitious.. > > Basically have sparse do a transform on its own expression tree and > > inject the very same crud we now do manually. This avoids cluttering the > > kernel tree with this nonsense. > > So, a call of a function declared with __acquires() or releases() is > interpreted by Sparse as if the call is immediately followed by an > increase or a decrease of the context. It wouldn't be very hard to > add a new attribute (something like __cond_context) and let Sparse do > as if a call to a function with such attribute is directly followed > by a test of its return value and a corresponding change in the context. > It would boil down to: > > extern bool spin_trylock(lock) __cond_context(lock); > > if (spin_trylock(lock)) { > /* do crap */ > spin_unlock(); > } > > behaving like the following code currently would: > > extern bool spin_trylock(lock); > > if (spin_trylock(lock)) { > __acquire(lock); > /* do crap */ > spin_unlock(); > } > > > Would something like this be satisfactory? Very much so, Thanks!