From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: john.levon@joyent.com
Cc: linux-sparse@vger.kernel.org, Toomas Soome <tsoome@me.com>
Subject: Re: [PATCH] correct sparcv9 defines
Date: Tue, 21 Jan 2020 01:13:22 +0100 [thread overview]
Message-ID: <20200121001322.zikj2xsacqt765fi@ltop.local> (raw)
In-Reply-To: <20200120103824.20746-1-john.levon@joyent.com>
On Mon, Jan 20, 2020 at 02:38:24AM -0800, john.levon@joyent.com wrote:
> From: Toomas Soome <tsoome@me.com>
>
> The SPARCV9 compile check needs to look for __sparcv9 on some systems,
> and should also define "sparc".
Hi.
Thanks for the patch.
Is it possible to have Toomas' Signed-off-by for this patch?
No need to resend the patch, just a reply to this email
saying it's OK is enough.
> case MACH_SPARC32:
> predefine("__sparc__", 1, "1");
> predefine("__sparc", 1, "1");
> + predefine("sparc", 1, "1");
I'm wondering if there is a real need for this one or if
it's just to reflect what GCC do? I'm a bit reluctant to
add it since it lies in the user's namespace. But I'm fine
to add it if there is a real use case for it (in which case
I'll just slightly change the patch to not predefine it if
one of the ISO dialect is selected (via --std=c99, ...)).
-- Luc
next prev parent reply other threads:[~2020-01-21 0:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 10:38 [PATCH] correct sparcv9 defines john.levon
2020-01-21 0:13 ` Luc Van Oostenryck [this message]
[not found] ` <BFD5AC88-E262-4579-BBD4-3C2BBBEAEBF9@me.com>
2020-01-22 22:48 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121001322.zikj2xsacqt765fi@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=john.levon@joyent.com \
--cc=linux-sparse@vger.kernel.org \
--cc=tsoome@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox