From: Oleg Nesterov <oleg@redhat.com>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Alexey Gladkov <gladkov.alexey@gmail.com>, linux-sparse@vger.kernel.org
Subject: [PATCH 2/2] dissect: kill no_member()
Date: Wed, 12 Feb 2020 11:04:37 +0100 [thread overview]
Message-ID: <20200212100437.GA23419@redhat.com> (raw)
In-Reply-To: <20200212100414.GA23415@redhat.com>
It is trivial and has a single caller, lookup_member().
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
dissect.c | 29 ++++++++++++++---------------
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/dissect.c b/dissect.c
index 05bddc8..40baf64 100644
--- a/dissect.c
+++ b/dissect.c
@@ -119,19 +119,6 @@ static usage_t fix_mode(struct symbol *type, usage_t mode)
return mode;
}
-static inline struct symbol *no_member(struct ident *name)
-{
- static struct symbol sym = {
- .type = SYM_BAD,
- .ctype.base_type = &bad_ctype,
- .kind = 'm',
- };
-
- sym.ident = name;
-
- return &sym;
-}
-
static struct symbol *report_member(usage_t mode, struct position *pos,
struct symbol *type, struct symbol *mem)
{
@@ -308,8 +295,20 @@ found:
static struct symbol *lookup_member(struct symbol *type, struct ident *name, int *addr)
{
- return __lookup_member(type, name, addr)
- ?: no_member(name);
+ struct symbol *mem = __lookup_member(type, name, addr);
+
+ if (!mem) {
+ static struct symbol bad_member = {
+ .type = SYM_BAD,
+ .ctype.base_type = &bad_ctype,
+ .kind = 'm',
+ };
+
+ mem = &bad_member;
+ mem->ident = name;
+ }
+
+ return mem;
}
static struct expression *peek_preop(struct expression *expr, int op)
--
2.5.0
prev parent reply other threads:[~2020-02-12 10:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 10:04 [PATCH 1/2] dissect: don't set ->ident = '?' in no_member() Oleg Nesterov
2020-02-12 10:04 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212100437.GA23419@redhat.com \
--to=oleg@redhat.com \
--cc=gladkov.alexey@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).