From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Sparse Mailing-list <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH] evaluate: mark evaluate_generic_selection() as static
Date: Sat, 30 May 2020 19:58:46 +0200 [thread overview]
Message-ID: <20200530175846.65it7dkpk4shjhrk@ltop.local> (raw)
In-Reply-To: <37ef319f-ed1e-071d-ff4b-cb3a997fbf65@ramsayjones.plus.com>
On Sat, May 30, 2020 at 06:51:38PM +0100, Ramsay Jones wrote:
>
> Commit c100a7ab (add support for _Generic, 2020-05-28) added the
> function evaluate_generic_selection() as an external symbol, without
> providing an external declaration in a header file. This causes
> sparse to issue a warning as part of the 'selfcheck' target.
>
> Since this function does not (currently) need to be an external symbol,
> mark it as static.
Hmm, yes. I should taste my own dogfood and use 'make selfcheck' ...
Thanks.
-- Luc
prev parent reply other threads:[~2020-05-30 17:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 17:51 [PATCH] evaluate: mark evaluate_generic_selection() as static Ramsay Jones
2020-05-30 17:58 ` Luc Van Oostenryck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200530175846.65it7dkpk4shjhrk@ltop.local \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox