From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH 2/3] add memory asm constraint for PPC
Date: Sat, 4 Jul 2020 15:57:46 +0200 [thread overview]
Message-ID: <20200704135747.87752-3-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20200704135747.87752-1-luc.vanoostenryck@gmail.com>
The 'Z' asm constraint is used for doing IO accessors on PPC but
isn't part of the 'common constraints'. It's responsible for
more than half of all warnings (with defconfig + allyesconfig).
Fix this by handling this constraint in a specific method for PPC.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
target-ppc.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/target-ppc.c b/target-ppc.c
index b138635b9103..c0d6068f436a 100644
--- a/target-ppc.c
+++ b/target-ppc.c
@@ -1,6 +1,7 @@
#include "symbol.h"
#include "target.h"
#include "machine.h"
+#include "expression.h"
static void predefine_ppc(const struct target *self)
@@ -15,6 +16,16 @@ static void predefine_ppc(const struct target *self)
predefine("_BIG_ENDIAN", 1, "1");
}
+static const char *asm_constraint_ppc(struct asm_operand *op, int c, const char *str)
+{
+ switch (c) {
+ case 'Z':
+ op->is_memory = true;
+ break;
+ }
+ return str;
+}
+
static void predefine_ppc32(const struct target *self)
{
@@ -32,6 +43,7 @@ const struct target target_ppc32 = {
.target_64bit = &target_ppc64,
.predefine = predefine_ppc32,
+ .asm_constraint = asm_constraint_ppc,
};
@@ -55,4 +67,5 @@ const struct target target_ppc64 = {
.target_32bit = &target_ppc32,
.predefine = predefine_ppc64,
+ .asm_constraint = asm_constraint_ppc,
};
--
2.27.0
next prev parent reply other threads:[~2020-07-04 13:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 13:57 [PATCH 0/3] teach sparse about arch specific asm constraints Luc Van Oostenryck
2020-07-04 13:57 ` [PATCH 1/3] add support for " Luc Van Oostenryck
2020-07-04 13:57 ` Luc Van Oostenryck
2020-07-04 13:57 ` Luc Van Oostenryck [this message]
2020-07-04 17:44 ` [PATCH 2/3] add memory asm constraint for PPC Ramsay Jones
2020-07-04 19:32 ` Luc Van Oostenryck
2020-07-04 21:07 ` Ramsay Jones
2020-07-04 22:44 ` Luc Van Oostenryck
2020-07-04 13:57 ` [PATCH 3/3] add memory asm constraint for S390 Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200704135747.87752-3-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox