From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Ben Dooks <ben.dooks@codethink.co.uk>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH 0/8] format check tweaks
Date: Mon, 5 Oct 2020 03:59:54 +0200 [thread overview]
Message-ID: <20201005020002.1108-1-luc.vanoostenryck@gmail.com> (raw)
Ben, these are small changes I think should be applied with
your series, on top of the patches I send yesterday.
I've pushed everything at:
git://github.com/lucvoo/sparse-dev.git format-check
If you're fine with these, I can squeeze them with the series.
There are also a few tests I don't agree with:
const void *ptr = ...
printf("%s", ptr);
These tests silently accept this, but they should warn.
But this can be fixed at a later step.
Luc Van Oostenryck (8):
need to strip SYM_NODE before comparing types
add helper get_nth_expression()
move the definition of FMT_{PRINTF,SCANF}
parse format attribute less verbosely
call verify_format_attribute() unconditionally
s/data/type/ for struct format_type
add support for "%ls"
add support for "%Lx" (and "%Ls")
evaluate.c | 4 +--
lib.h | 5 +++
parse.c | 30 +++++++----------
symbol.h | 7 ++++
validation/varargs-format-dyn-prec.c | 11 ++++++
verify-format.c | 50 ++++++++++++++++------------
6 files changed, 65 insertions(+), 42 deletions(-)
create mode 100644 validation/varargs-format-dyn-prec.c
--
2.28.0
next reply other threads:[~2020-10-05 2:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 1:59 Luc Van Oostenryck [this message]
2020-10-05 1:59 ` [PATCH 1/8] need to strip SYM_NODE before comparing types Luc Van Oostenryck
2020-10-05 1:59 ` [PATCH 2/8] add helper get_nth_expression() Luc Van Oostenryck
2020-10-05 1:59 ` [PATCH 3/8] move the definition of FMT_{PRINTF,SCANF} Luc Van Oostenryck
2020-10-05 1:59 ` [PATCH 4/8] parse format attribute less verbosely Luc Van Oostenryck
2020-10-05 1:59 ` [PATCH 5/8] call verify_format_attribute() unconditionally Luc Van Oostenryck
2020-10-05 2:00 ` [PATCH 6/8] s/data/type/ for struct format_type Luc Van Oostenryck
2020-10-05 2:00 ` [PATCH 7/8] add support for "%ls" Luc Van Oostenryck
2020-10-05 2:00 ` [PATCH 8/8] add support for "%Lx" (and "%Ls") Luc Van Oostenryck
2020-10-05 9:04 ` [PATCH 0/8] format check tweaks Ben Dooks
2020-10-05 23:47 ` Luc Van Oostenryck
2020-10-11 19:51 ` Ben Dooks
2020-10-12 22:38 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005020002.1108-1-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox