Re: [PATCH] asm-out0: fix a test failure on 32-bit systems

[Luc Van Oostenryck <luc.vanoostenryck@gmail.com>]

On Sat, Feb 27, 2021 at 05:15:19PM +0000, Ramsay Jones wrote:
> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> 
> Hi Luc,
> 
> So, I did some 32-bit testing this afternoon ... ;-)

Good :)
 
> The problem here being s/symaddr.64/symaddr.32/, of course. I did the
> minimum necessary to get it to work (adding the -m64), so no creative
> solutions here (not that I could think of any)!
> 
> [I suppose that I could also have created asm-out1.c as a copy and then
> done s/symaddr.64/symaddr.32/, s/-m64/-m32/, but I didn't.]

The ideal solution, at least from a functional point of view, would be
to change the "32" by something like "$POINTER_SIZE$" and doing the
substitution when comparing the files but that would complicate a bit
more the testing and make it slower. Another solution would simply to
add for such tests an option to not display the instruction's size.

In this case, what you did is, IMO, the correct solution because the test
is obviously not size dependent, it's just that the size is displayed.

Thanks,
-- Luc