From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: linux-sparse@vger.kernel.org
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH 3/6] let insert_select() use insert_last_instruction()
Date: Sun, 21 Mar 2021 17:16:06 +0100 [thread overview]
Message-ID: <20210321161609.45905-4-luc.vanoostenryck@gmail.com> (raw)
In-Reply-To: <20210321161609.45905-1-luc.vanoostenryck@gmail.com>
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
linearize.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/linearize.c b/linearize.c
index e6aa01f1b9fe..4787689b37b8 100644
--- a/linearize.c
+++ b/linearize.c
@@ -697,11 +697,7 @@ void insert_select(struct basic_block *bb, struct instruction *br, struct instru
pseudo_t target;
struct instruction *select;
- /* Remove the 'br' */
- delete_last_instruction(&bb->insns);
-
select = alloc_typed_instruction(OP_SEL, phi_node->type);
- select->bb = bb;
assert(br->cond);
use_pseudo(select, br->cond, &select->src1);
@@ -714,8 +710,7 @@ void insert_select(struct basic_block *bb, struct instruction *br, struct instru
use_pseudo(select, if_true, &select->src2);
use_pseudo(select, if_false, &select->src3);
- add_instruction(&bb->insns, select);
- add_instruction(&bb->insns, br);
+ insert_last_instruction(bb, select);
}
static inline int bb_empty(struct basic_block *bb)
--
2.31.0
next prev parent reply other threads:[~2021-03-21 16:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 16:16 [PATCH 0/6] use an helper to add an instruction to a BB Luc Van Oostenryck
2021-03-21 16:16 ` [PATCH 1/6] add insert_last_instruction() Luc Van Oostenryck
2021-03-21 16:16 ` [PATCH 2/6] replace add_instruction_to_end() by insert_last_instruction() Luc Van Oostenryck
2021-03-21 16:16 ` Luc Van Oostenryck [this message]
2021-03-21 16:16 ` [PATCH 4/6] let insert_phis() use insert_last_instruction() Luc Van Oostenryck
2021-03-21 16:16 ` [PATCH 5/6] let find_dominating_parents() " Luc Van Oostenryck
2021-03-21 16:16 ` [PATCH 6/6] let ssa_rename_phi() " Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210321161609.45905-4-luc.vanoostenryck@gmail.com \
--to=luc.vanoostenryck@gmail.com \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).