linux-sparse.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Cree <mcree@orcon.net.nz>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Matt Turner <mattst88@gmail.com>,
	"James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
	Helge Deller <deller@gmx.de>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	alpha <linux-alpha@vger.kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-parisc@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
	Sparse Mailing-list <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH v2 0/4] Introduce and use absolute_pointer macro
Date: Sat, 18 Sep 2021 21:51:34 +1200	[thread overview]
Message-ID: <20210918095134.GA5001@tower> (raw)
In-Reply-To: <CAHk-=wgQ4jsPadbo4kr4=UKn0nR+UvWUZF9Q-xv0QUXb33SVRA@mail.gmail.com>

On Thu, Sep 16, 2021 at 11:35:36AM -0700, Linus Torvalds wrote:
> On Wed, Sep 15, 2021 at 3:33 PM Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > drivers/net/ethernet/3com/3c515.c: In function 'corkscrew_start_xmit':
> > drivers/net/ethernet/3com/3c515.c:1053:22: error:
> >         cast from pointer to integer of different size
> >
> > That is a typecast from a pointer to an int, which is then sent to an
> > i/o port. That driver should probably be disabled for 64-bit builds.
> 
> Naah. I think the Jensen actually had an ISA slot. Came with a
> whopping 8MB too, so the ISA DMA should work just fine.
> 
> Or maybe it was EISA only? I really don't remember.
> 
> It's possible that alpha should get rid of the ISA config option, and
> use ISA_BUS instead. That would be the proper config if there aren't
> actually any ISA _slots_, and it would disable the 3c515 driver.
> 
> But it turns out that the compile error is easy to fix. Just make it
> use isa_virt_to_bus(), which that driver does elsewhere anyway.
> 
> I have no way - or interest - to test that on real hardware, but I did
> check that if I relax the config I can at least build it cleanly on
> x86-64 with that change.
> 
> It can't make matters worse, and it's the RightThing(tm).
> 
> Since Micheal replied about that other alpha issue, maybe he knows
> about the ISA slot situation too?

Ah, yeah, not really.  I am not familiar with the Jensen hardware,
and have never played around with the EISA slot on the Alphas I do
have.

Cheers
Michael.

  reply	other threads:[~2021-09-18  9:52 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15  3:52 [PATCH v2 0/4] Introduce and use absolute_pointer macro Guenter Roeck
2021-09-15  3:52 ` [PATCH v2 1/4] compiler.h: Introduce " Guenter Roeck
2021-09-15  7:07   ` Geert Uytterhoeven
2021-09-15  7:13   ` Geert Uytterhoeven
2021-09-15 14:03     ` Guenter Roeck
2021-09-15  3:52 ` [PATCH v2 2/4] net: i825xx: Use absolute_pointer for memcpy from fixed memory location Guenter Roeck
2021-09-15  7:08   ` Geert Uytterhoeven
2021-09-15  3:52 ` [PATCH v2 3/4] alpha: Move setup.h out of uapi Guenter Roeck
2021-09-15  3:52 ` [PATCH v2 4/4] alpha: Use absolute_pointer to define COMMAND_LINE Guenter Roeck
2021-09-15 19:18 ` [PATCH v2 0/4] Introduce and use absolute_pointer macro Linus Torvalds
2021-09-15 19:35   ` Guenter Roeck
2021-09-15 19:47     ` Linus Torvalds
2021-09-15 19:50       ` Linus Torvalds
2021-09-15 21:19         ` Linus Torvalds
2021-09-16  7:02           ` Anders Larsen
2021-09-16 16:25             ` Linus Torvalds
2021-09-15 20:30       ` Helge Deller
2021-09-15 22:33       ` Guenter Roeck
2021-09-16 18:35         ` Linus Torvalds
2021-09-18  9:51           ` Michael Cree [this message]
2021-09-18 13:11             ` Ulrich Teichert
2021-09-18 17:04               ` Linus Torvalds
2021-09-18 17:17                 ` Thorsten Glaser
2021-09-18 17:21                   ` Linus Torvalds
2021-09-18 17:28                 ` Linus Torvalds
2021-09-18 20:26                 ` Ulrich Teichert
2021-09-18 20:46                   ` Linus Torvalds
2021-09-18 21:12                     ` Linus Torvalds
2021-09-18 22:09                   ` Linus Torvalds
2021-09-19 15:13                     ` Dave Taht
2021-09-20 18:25                     ` Ulrich Teichert
2021-09-20 18:46                       ` Linus Torvalds
2021-09-20 18:59                         ` Matt Turner
2021-09-20 19:45                           ` Linus Torvalds
2021-09-21 19:13                         ` Ulrich Teichert
2021-09-21 20:42                           ` Linus Torvalds
2021-09-21 21:39                           ` Linus Torvalds
2021-09-22 20:50                             ` Ulrich Teichert
2021-09-16 19:47         ` Linus Torvalds
2021-09-16  0:34   ` Michael Cree

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210918095134.GA5001@tower \
    --to=mcree@orcon.net.nz \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=davem@davemloft.net \
    --cc=deller@gmx.de \
    --cc=geert@linux-m68k.org \
    --cc=ink@jurassic.park.msu.ru \
    --cc=kuba@kernel.org \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mattst88@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=rth@twiddle.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).