From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
x86@kernel.org, llvm@lists.linux.dev,
linux-sparse@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>,
Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH] objtool: prefer memory clobber & %= to volatile & __COUNTER__
Date: Tue, 18 Jan 2022 11:22:56 -0800 [thread overview]
Message-ID: <20220118192256.jzk5dnceeusq7x7u@treble> (raw)
In-Reply-To: <YeQei0xNzMq7bFdg@zn.tnic>
On Sun, Jan 16, 2022 at 02:32:59PM +0100, Borislav Petkov wrote:
> so I like the local label and how it is more readable this way.
>
> So, provided the memory clobber works (I wonder here if Josh has some
> concrete failing cases which could be tested with your version) and
> after the nitpicks have been addressed
>
> Acked-by: Borislav Petkov <bp@suse.de>
I think Nick was already able to recreate the original issue. I'll run
it through some more testing.
I wanted to make this change years ago, but couldn't because of legacy
toolchains. Here's hoping this is the final solution for those @#$%^
macros.
Boris, thanks for looping Nick in, I should have done so to begin with.
--
Josh
next prev parent reply other threads:[~2022-01-18 19:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 1:05 [PATCH] objtool: prefer memory clobber & %= to volatile & __COUNTER__ Nick Desaulniers
2022-01-14 21:58 ` Nathan Chancellor
2022-01-16 13:32 ` Borislav Petkov
2022-01-18 19:22 ` Josh Poimboeuf [this message]
2022-01-18 23:01 ` Josh Poimboeuf
2022-01-18 23:33 ` Borislav Petkov
2022-01-19 0:03 ` Josh Poimboeuf
2022-01-19 10:01 ` Borislav Petkov
2022-01-24 23:26 ` Nick Desaulniers
2022-01-24 23:38 ` Nick Desaulniers
2022-01-25 18:49 ` Borislav Petkov
2022-01-25 23:31 ` Segher Boessenkool
2022-01-26 0:59 ` Nick Desaulniers
2022-01-26 2:12 ` Nick Desaulniers
2022-01-26 11:13 ` Segher Boessenkool
2022-01-31 20:45 ` Nick Desaulniers
2022-01-31 22:13 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220118192256.jzk5dnceeusq7x7u@treble \
--to=jpoimboe@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gor@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=luc.vanoostenryck@gmail.com \
--cc=mingo@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).