From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: linux-sparse@vger.kernel.org, Kito Cheng <kito.cheng@gmail.com>,
linux-riscv@lists.infradead.org, mkl@pengutronix.de,
aurelien@aurel32.net,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v1 2/6] RISC-V: Match GCC's semantics for multiple -march instances
Date: Sat, 21 May 2022 23:52:31 +0200 [thread overview]
Message-ID: <20220521215231.66yvpgji64uqbyzv@mail> (raw)
In-Reply-To: <20220402050041.21302-3-palmer@rivosinc.com>
On Fri, Apr 01, 2022 at 10:00:37PM -0700, Palmer Dabbelt wrote:
> GCC's semantics for "-march=X -march=Y" are that Y entirely overrides X,
> but sparse takes the union of these two ISA strings.
OK, but then I prefer to explicitly clear riscv_flags at the start
of the function, like:
diff --git a/target-riscv.c b/target-riscv.c
index 3bba7c15ff1f..ca38d76e6465 100644
--- a/target-riscv.c
+++ b/target-riscv.c
@@ -54,6 +54,9 @@ static void parse_march_riscv(const char *arg)
};
int i;
+ // Each -march=.. options entirely overrides previous ones
+ riscv_flags = 0;
+
for (i = 0; i < ARRAY_SIZE(basic_sets); i++) {
const char *pat = basic_sets[i].pattern;
size_t len = strlen(pat);
-- Luc
next prev parent reply other threads:[~2022-05-21 21:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-02 5:00 [PATCH v1 0/6] RISC-V -march handling improvements Palmer Dabbelt
2022-04-02 5:00 ` [PATCH v1 1/6] RISC-V: Respect -Wsparse-error for -march errors Palmer Dabbelt
2022-05-21 21:46 ` Luc Van Oostenryck
2022-04-02 5:00 ` [PATCH v1 2/6] RISC-V: Match GCC's semantics for multiple -march instances Palmer Dabbelt
2022-05-21 21:52 ` Luc Van Oostenryck [this message]
2022-04-02 5:00 ` [PATCH v1 3/6] RISC-V: Remove the unimplemented ISA extensions Palmer Dabbelt
2022-05-21 22:05 ` Luc Van Oostenryck
2022-04-02 5:00 ` [PATCH v1 4/6] RISC-V: Remove "g" from the extension list Palmer Dabbelt
2022-04-02 5:00 ` [PATCH v1 5/6] RISC-V: Add the Zicsr extension Palmer Dabbelt
2022-04-02 5:00 ` [PATCH v1 6/6] RISC-V: Add the Zifencei extension Palmer Dabbelt
2022-04-04 17:52 ` [PATCH v1 0/6] RISC-V -march handling improvements Marc Kleine-Budde
2022-04-04 23:15 ` Palmer Dabbelt
2022-05-21 21:23 ` Luc Van Oostenryck
2022-07-05 23:09 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220521215231.66yvpgji64uqbyzv@mail \
--to=luc.vanoostenryck@gmail.com \
--cc=aurelien@aurel32.net \
--cc=kito.cheng@gmail.com \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sparse@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=palmer@rivosinc.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox