From: Luc Van Oostenryck <lucvoo@kernel.org>
To: linux-sparse@vger.kernel.org
Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: [PATCH 4/6] inline: avoid needless intermediate vars
Date: Sun, 26 Jun 2022 15:07:46 +0200 [thread overview]
Message-ID: <20220626130748.74163-5-lucvoo@kernel.org> (raw)
In-Reply-To: <20220626130748.74163-1-lucvoo@kernel.org>
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
In inline_function(), the we need to iterate over the parameters
and the (effective) arguments. An itermediate variable is used for
each: "name_list" and "arg_list".
These confuse me a lot (especially "name_list", "param_list" would
be much more OK) and are just used once.
So, avoid using an intermediate variable for these.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
inline.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/inline.c b/inline.c
index 4696eb509f9a..a6f9252ab0ff 100644
--- a/inline.c
+++ b/inline.c
@@ -516,9 +516,8 @@ int inline_function(struct expression *expr, struct symbol *sym)
{
struct symbol_list * fn_symbol_list;
struct symbol *fn = sym->ctype.base_type;
- struct expression_list *arg_list = expr->args;
struct statement *stmt = alloc_statement(expr->pos, STMT_COMPOUND);
- struct symbol_list *name_list, *arg_decl;
+ struct symbol_list *arg_decl;
struct symbol *name;
struct expression *arg;
@@ -529,8 +528,6 @@ int inline_function(struct expression *expr, struct symbol *sym)
if (fn->expanding)
return 0;
- name_list = fn->arguments;
-
expr->type = EXPR_STATEMENT;
expr->statement = stmt;
expr->ctype = fn->ctype.base_type;
@@ -538,8 +535,8 @@ int inline_function(struct expression *expr, struct symbol *sym)
fn_symbol_list = create_symbol_list(sym->inline_symbol_list);
arg_decl = NULL;
- PREPARE_PTR_LIST(name_list, name);
- FOR_EACH_PTR(arg_list, arg) {
+ PREPARE_PTR_LIST(fn->arguments, name);
+ FOR_EACH_PTR(expr->args, arg) {
struct symbol *a = alloc_symbol(arg->pos, SYM_NODE);
if (name) {
--
2.36.1
next prev parent reply other threads:[~2022-06-26 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-26 13:07 [PATCH 0/6] cleanup related to inlining of variadic functions Luc Van Oostenryck
2022-06-26 13:07 ` [PATCH 1/6] inline: add testcases for inlining of variadics Luc Van Oostenryck
2022-06-26 13:07 ` [PATCH 2/6] inline: comment about creating node of node on variadics Luc Van Oostenryck
2022-06-26 14:42 ` Ramsay Jones
2022-06-26 16:07 ` Luc Van Oostenryck
2022-06-26 13:07 ` [PATCH 3/6] inline: declaration of the variadic vars is useless Luc Van Oostenryck
2022-06-26 13:07 ` Luc Van Oostenryck [this message]
2022-06-26 14:45 ` [PATCH 4/6] inline: avoid needless intermediate vars Ramsay Jones
2022-06-26 13:07 ` [PATCH 5/6] inline: allocate statement after guards Luc Van Oostenryck
2022-06-26 13:07 ` [PATCH 6/6] inline: free symbol list after use Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220626130748.74163-5-lucvoo@kernel.org \
--to=lucvoo@kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).