From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F2F51AAE31 for ; Thu, 3 Oct 2024 18:39:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727980791; cv=none; b=S5cmTCxaY1npWXDMSCpcIyMqoKKiAH9ITFaljc2RnjNGsNItIP1fIbJFoTCZsx7GpRSogrBBNUU25fkNA/f7FVe4EhU3/WsaOmsU+pJd1T8NI0gm+1/H9V8XWUUxN88mZeWCbKPZlXAZ6BvIz1K0CiPVgxExe4i4s8iDhUR2YTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727980791; c=relaxed/simple; bh=DhOoRBLHjJo6iKb0pokJEyuf1Q43DOLSfMfmpPXYJ6k=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XbiBhfuwSlhfcKj38oPTruqO3+CNZx76LQDMr7R6F0U9ftDXpqRFjYiic0dgUIV8Nwept9H3/+3hPz0GRuau2/1J7BPnxgzHF02w0wVOjJVYOG7Yq/GyvxUUv9xFRTUu20GgrNCB/5119zbilb2SZCguJsvjAATlh6B5Lf61Jnk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b=XNhVgTjL; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b="XNhVgTjL" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-20b833f9b35so11719005ad.2 for ; Thu, 03 Oct 2024 11:39:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727980789; x=1728585589; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=8NOfF+iASIgN1enWQgY9wUU6upF2RxXXkbqZYau3r2Q=; b=XNhVgTjL/MD24AMoimalZIIxSyRbDfj8HXs5w8MVirHEh8EFO6wPMmctsXDYVzzaqF TPAkKml+5QcJGfw9Z+n9Ukvifv8Gu55uG5+0zIOd0pdFDWxQ4QMBdWA0LgNq8ki4Je6w 5lLa65sGi6X26LzwfdjEcKYvzuvJDZmvESL4VvL+MUjduzfO3UsDOP5Xy56kas8aP5CG veiStkFRAK3/COF/xr1d3OVaoJw+G+6vRUxQgRPH86ywNEN1Lua4HjlJ1QcYTLdm4gPE ANin45X62pmbx0Lj9o+WsrxoFDVQj8kAAuzGWgd7gkq0Ua+KDv8kAL/tz2bboMI8VCVG xHTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727980789; x=1728585589; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8NOfF+iASIgN1enWQgY9wUU6upF2RxXXkbqZYau3r2Q=; b=CdLso88sdG4vzLNvY2FB/fE1pwC5xDJAtzVtj+SnAwm+TTD5Un2+N4PJPclyUZ+Zfs yaOe+Yh/GOL0XpQYK8nFnSkbyv66XhQQuSmf3wxv/H9aDsCqeNEpv5zEl6JTJoCFio2j jkeulPVG5rhz45lAhA+9u58Ty4oVVhbmtdKAoS1zZEsTB0uLEQ/llpcdbVvROMfydlHt OUN6U9VFd1OugqXgn3kdKa6+Sm8Qv383E2sc9sW+BbG+Gf+xfwekByh4Ie+zqjsAj2N9 KN1gc+imi456P+f/byjDi24KFdsLrn6UfoBSSNN42jcJDoxKVYSTFxvECOkmpuOMZHOm RZSA== X-Forwarded-Encrypted: i=1; AJvYcCVVycDdC6nsByLeSQ6GObrlvvT223Wl4tLcK8+yRA7Mj23zt2hCWNsedHAYF0e0oqZ9SUt8p8hNm2Kik9Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxqigFV5/bEegrtHDnLn2tCApgo1gGOwCVIJ9FpQQA/WRWL6Omc y0xoaEEBcXR+/EDANUeRjaLFEBgKFN9Y0v3cGO/KoM1fIBL4D6S55ZPHq/WT/eU= X-Google-Smtp-Source: AGHT+IGIHsGZj7FRyxDSBw/wKYL5XsHu8ck09mUVeMUbnS/YK8RyE1dWDEsQDtAZooeWNUfv2dlAew== X-Received: by 2002:a17:902:e881:b0:205:5dfe:7be with SMTP id d9443c01a7336-20bfdfeb5b4mr1953015ad.26.1727980789435; Thu, 03 Oct 2024 11:39:49 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20beeca2256sm12086035ad.91.2024.10.03.11.39.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2024 11:39:49 -0700 (PDT) Date: Thu, 3 Oct 2024 11:39:47 -0700 From: Stephen Hemminger To: Edward Cree Cc: Moon Yeounsu , Eric Dumazet , davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, linux@weissschuh.net, j.granados@samsung.com, judyhsiao@chromium.org, James.Z.Li@dell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Simon Horman , linux-sparse@vger.kernel.org Subject: Re: [PATCH net] net: add inline annotation to fix the build warning Message-ID: <20241003113947.6e605b8c@hermes.local> In-Reply-To: References: <20241001193352.151102-1-yyyynoom@gmail.com> Precedence: bulk X-Mailing-List: linux-sparse@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 3 Oct 2024 17:11:26 +0100 Edward Cree wrote: > On 03/10/2024 16:33, Moon Yeounsu wrote: > > On 03/10/2024 15:19, Eric Dumazet wrote: > >> It also does not know about conditional locking, it is quite useless. > > So... What do you think about who wants to send the patch to silence > > the Sparse's warning message, nevertheless? In my experience, conditional locking is often a cause of bugs.