Re: [PATCH v2] build_bug.h: more user friendly error messages in BUILD_BUG_ON_ZERO()

[Kees Cook <kees@kernel.org>]

On Sat, Mar 29, 2025 at 01:48:50AM +0900, Vincent Mailhol wrote:
> __BUILD_BUG_ON_ZERO_MSG(), as introduced in [1], makes it possible to
> do a static assertions in expressions. The direct benefit is to
> provide a meaningful error message instead of the cryptic negative
> bitfield size error message currently returned by BUILD_BUG_ON_ZERO():
> 
>   ./include/linux/build_bug.h:16:51: error: negative width in bit-field '<anonymous>'
>      16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
>         |                                                   ^
> 
> Get rid of BUILD_BUG_ON_ZERO()'s bitfield size hack. Instead rely on
> __BUILD_BUG_ON_ZERO_MSG() which in turn relies on C11's
> _Static_assert().
> 
> Use some macro magic, similarly to static_assert(), to either use an
> optional error message provided by the user or, when omitted, to
> produce a default error message by stringifying the tested
> expression. With this, for example:
> 
>   BUILD_BUG_ON_ZERO(1 > 0)
> 
> would now throw:
> 
>   ./include/linux/compiler.h:197:62: error: static assertion failed: "1 > 0 is true"

This is so much easier to read! Thanks for this. :)

If no one else snags it, I can take this via the hardening tree for
-next once -rc2 is released.

-- 
Kees Cook