public inbox for linux-sparse@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	"Eugenio Pérez" <eperezma@redhat.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Al Viro" <viro@zeniv.linux.org.uk>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Alexey Dobriyan" <adobriyan@gmail.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Arnd Bergmann" <arnd@kernel.org>,
	"Borislav Petkov" <bp@alien8.de>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"David Laight" <David.Laight@ACULAB.COM>,
	"David Lechner" <dlechner@baylibre.com>,
	"Dinh Nguyen" <dinguyen@kernel.org>,
	"Eduard Zingerman" <eddyz87@gmail.com>,
	"Gatlin Newhouse" <gatlin.newhouse@gmail.com>,
	"Hao Luo" <haoluo@google.com>, "Ingo Molnar" <mingo@redhat.com>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Jakub Sitnicki" <jakub@cloudflare.com>,
	"Jan Hendrik Farr" <kernel@jfarr.cc>,
	"Jason Wang" <jasowang@redhat.com>,
	"Jiri Olsa" <jolsa@kernel.org>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	"Josh Poimboeuf" <jpoimboe@kernel.org>,
	"KP Singh" <kpsingh@kernel.org>, "Kees Cook" <kees@kernel.org>,
	"Luc Van Oostenryck" <luc.vanoostenryck@gmail.com>,
	"Marc Herbert" <Marc.Herbert@linux.intel.com>,
	"Martin KaFai Lau" <martin.lau@linux.dev>,
	"Mateusz Guzik" <mjguzik@gmail.com>,
	"Michal Luczaj" <mhal@rbox.co>, "Miguel Ojeda" <ojeda@kernel.org>,
	"Mykola Lysenko" <mykolal@fb.com>, NeilBrown <neil@brown.name>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Przemek Kitszel" <przemyslaw.kitszel@intel.com>,
	"Sami Tolvanen" <samitolvanen@google.com>,
	"Shuah Khan" <shuah@kernel.org>, "Song Liu" <song@kernel.org>,
	"Stanislav Fomichev" <sdf@fomichev.me>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Thorsten Blum" <thorsten.blum@linux.dev>,
	"Uros Bizjak" <ubizjak@gmail.com>,
	"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
	"Yafang Shao" <laoar.shao@gmail.com>,
	"Ye Bin" <yebin10@huawei.com>,
	"Yonghong Song" <yonghong.song@linux.dev>,
	"Yufeng Wang" <wangyufeng@kylinos.cn>,
	bpf@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-sparse@vger.kernel.org, virtualization@lists.linux.dev,
	x86@kernel.org
Subject: [PATCH v2.1 3/7] fs/proc: replace "__auto_type" with "const auto"
Date: Sat, 19 Jul 2025 23:58:43 -0700	[thread overview]
Message-ID: <20250720065844.2860000-1-hpa@zytor.com> (raw)
In-Reply-To: <20250720065045.2859105-4-hpa@zytor.com>

Replace use of "__auto_type" in fs/proc/inode.c with "const auto".

Suggested-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
Reviewed-by: Alexey Dobriyan <adobriyan@gmail.com>
---
 fs/proc/inode.c | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

[ v2 of this patch was an obvious thinko, this is the correct one ]

diff --git a/fs/proc/inode.c b/fs/proc/inode.c
index 3604b616311c..8b90ab9b9cfc 100644
--- a/fs/proc/inode.c
+++ b/fs/proc/inode.c
@@ -303,7 +303,7 @@ static ssize_t proc_reg_read_iter(struct kiocb *iocb, struct iov_iter *iter)
 
 static ssize_t pde_read(struct proc_dir_entry *pde, struct file *file, char __user *buf, size_t count, loff_t *ppos)
 {
-	__auto_type read = pde->proc_ops->proc_read;
+	const auto read = pde->proc_ops->proc_read;
 	if (read)
 		return read(file, buf, count, ppos);
 	return -EIO;
@@ -325,7 +325,7 @@ static ssize_t proc_reg_read(struct file *file, char __user *buf, size_t count,
 
 static ssize_t pde_write(struct proc_dir_entry *pde, struct file *file, const char __user *buf, size_t count, loff_t *ppos)
 {
-	__auto_type write = pde->proc_ops->proc_write;
+	const auto write = pde->proc_ops->proc_write;
 	if (write)
 		return write(file, buf, count, ppos);
 	return -EIO;
@@ -347,7 +347,7 @@ static ssize_t proc_reg_write(struct file *file, const char __user *buf, size_t
 
 static __poll_t pde_poll(struct proc_dir_entry *pde, struct file *file, struct poll_table_struct *pts)
 {
-	__auto_type poll = pde->proc_ops->proc_poll;
+	const auto poll = pde->proc_ops->proc_poll;
 	if (poll)
 		return poll(file, pts);
 	return DEFAULT_POLLMASK;
@@ -369,7 +369,7 @@ static __poll_t proc_reg_poll(struct file *file, struct poll_table_struct *pts)
 
 static long pde_ioctl(struct proc_dir_entry *pde, struct file *file, unsigned int cmd, unsigned long arg)
 {
-	__auto_type ioctl = pde->proc_ops->proc_ioctl;
+	const auto ioctl = pde->proc_ops->proc_ioctl;
 	if (ioctl)
 		return ioctl(file, cmd, arg);
 	return -ENOTTY;
@@ -392,7 +392,7 @@ static long proc_reg_unlocked_ioctl(struct file *file, unsigned int cmd, unsigne
 #ifdef CONFIG_COMPAT
 static long pde_compat_ioctl(struct proc_dir_entry *pde, struct file *file, unsigned int cmd, unsigned long arg)
 {
-	__auto_type compat_ioctl = pde->proc_ops->proc_compat_ioctl;
+	const auto compat_ioctl = pde->proc_ops->proc_compat_ioctl;
 	if (compat_ioctl)
 		return compat_ioctl(file, cmd, arg);
 	return -ENOTTY;
@@ -414,7 +414,7 @@ static long proc_reg_compat_ioctl(struct file *file, unsigned int cmd, unsigned
 
 static int pde_mmap(struct proc_dir_entry *pde, struct file *file, struct vm_area_struct *vma)
 {
-	__auto_type mmap = pde->proc_ops->proc_mmap;
+	const auto mmap = pde->proc_ops->proc_mmap;
 	if (mmap)
 		return mmap(file, vma);
 	return -EIO;
@@ -497,7 +497,7 @@ static int proc_reg_open(struct inode *inode, struct file *file)
 	if (!use_pde(pde))
 		return -ENOENT;
 
-	__auto_type release = pde->proc_ops->proc_release;
+	const auto release = pde->proc_ops->proc_release;
 	if (release) {
 		pdeo = kmem_cache_alloc(pde_opener_cache, GFP_KERNEL);
 		if (!pdeo) {
@@ -534,10 +534,9 @@ static int proc_reg_release(struct inode *inode, struct file *file)
 	struct pde_opener *pdeo;
 
 	if (pde_is_permanent(pde)) {
-		__auto_type release = pde->proc_ops->proc_release;
-		if (release) {
+		const auto release = pde->proc_ops->proc_release;
+		if (release)
 			return release(inode, file);
-		}
 		return 0;
 	}
 
-- 
2.50.1


  reply	other threads:[~2025-07-20  7:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-20  6:50 [PATCH v2 0/7] Replace "__auto_type" with "auto" H. Peter Anvin
2025-07-20  6:50 ` [PATCH v2 1/7] compiler_types.h: add "auto" as a macro for "__auto_type" H. Peter Anvin
2025-07-20 16:36   ` Miguel Ojeda
2025-07-20  6:50 ` [PATCH v2 2/7] include/linux: change "__auto_type" to "auto" H. Peter Anvin
2025-07-20  6:50 ` [PATCH v2 3/7] fs/proc: replace "__auto_type" with "const auto" H. Peter Anvin
2025-07-20  6:58   ` H. Peter Anvin [this message]
2025-07-20  6:50 ` [PATCH v2 4/7] arch/nios2: replace "__auto_type" and adjacent equivalent with "auto" H. Peter Anvin
2025-07-22 16:40   ` Dinh Nguyen
2025-07-20  6:50 ` [PATCH v2 5/7] arch/x86: replace "__auto_type" " H. Peter Anvin
2025-07-20  6:50 ` [PATCH v2 6/7] selftests/bpf: " H. Peter Anvin
2025-07-21 22:13   ` Eduard Zingerman
2025-07-20  6:50 ` [PATCH v2 7/7] tools/virtio: " H. Peter Anvin
2025-07-20 18:07 ` [PATCH v2 0/7] Replace " Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250720065844.2860000-1-hpa@zytor.com \
    --to=hpa@zytor.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=Marc.Herbert@linux.intel.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrii@kernel.org \
    --cc=arnd@kernel.org \
    --cc=ast@kernel.org \
    --cc=bp@alien8.de \
    --cc=bpf@vger.kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=daniel@iogearbox.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=dinguyen@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=eddyz87@gmail.com \
    --cc=eperezma@redhat.com \
    --cc=gatlin.newhouse@gmail.com \
    --cc=haoluo@google.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jakub@cloudflare.com \
    --cc=jasowang@redhat.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=kees@kernel.org \
    --cc=kernel@jfarr.cc \
    --cc=kpsingh@kernel.org \
    --cc=laoar.shao@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=martin.lau@linux.dev \
    --cc=mhal@rbox.co \
    --cc=mingo@redhat.com \
    --cc=mjguzik@gmail.com \
    --cc=mst@redhat.com \
    --cc=mykolal@fb.com \
    --cc=neil@brown.name \
    --cc=ojeda@kernel.org \
    --cc=peterz@infradead.org \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=samitolvanen@google.com \
    --cc=sdf@fomichev.me \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=thorsten.blum@linux.dev \
    --cc=torvalds@linux-foundation.org \
    --cc=ubizjak@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=virtualization@lists.linux.dev \
    --cc=wangyufeng@kylinos.cn \
    --cc=x86@kernel.org \
    --cc=xuanzhuo@linux.alibaba.com \
    --cc=yebin10@huawei.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox