From: kernel test robot <lkp@intel.com>
To: Vincent Mailhol <mailhol@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nsc@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Chris Mason <chris.mason@fusionio.com>,
David Sterba <dsterba@suse.com>, Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-kbuild@vger.kernel.org,
linux-sparse@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, dri-devel@lists.freedesktop.org,
linux-btrfs@vger.kernel.org, linux-hardening@vger.kernel.org,
Vincent Mailhol <mailhol@kernel.org>
Subject: Re: [PATCH v3 3/3] overflow: Remove is_non_negative() and is_negative()
Date: Mon, 22 Dec 2025 18:03:51 +0800 [thread overview]
Message-ID: <202512221735.mRV4BZqB-lkp@intel.com> (raw)
In-Reply-To: <20251220-remove_wtype-limits-v3-3-24b170af700e@kernel.org>
Hi Vincent,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 3e7f562e20ee87a25e104ef4fce557d39d62fa85]
url: https://github.com/intel-lab-lkp/linux/commits/Vincent-Mailhol/kbuild-remove-gcc-s-Wtype-limits/20251220-190509
base: 3e7f562e20ee87a25e104ef4fce557d39d62fa85
patch link: https://lore.kernel.org/r/20251220-remove_wtype-limits-v3-3-24b170af700e%40kernel.org
patch subject: [PATCH v3 3/3] overflow: Remove is_non_negative() and is_negative()
config: x86_64-randconfig-161-20251222 (https://download.01.org/0day-ci/archive/20251222/202512221735.mRV4BZqB-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512221735.mRV4BZqB-lkp@intel.com/
smatch warnings:
fs/libfs.c:1628 generic_check_addressable() warn: unsigned '*_d' is never less than zero.
fs/libfs.c:1628 generic_check_addressable() warn: unsigned '_a' is never less than zero.
mm/vmalloc.c:4708 remap_vmalloc_range_partial() warn: unsigned '*_d' is never less than zero.
mm/vmalloc.c:4708 remap_vmalloc_range_partial() warn: unsigned '_a' is never less than zero.
vim +1628 fs/libfs.c
1b061d9247f71c Christoph Hellwig 2010-05-26 1613
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1614 /**
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1615 * generic_check_addressable - Check addressability of file system
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1616 * @blocksize_bits: log of file system block size
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1617 * @num_blocks: number of blocks in file system
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1618 *
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1619 * Determine whether a file system with @num_blocks blocks (and a
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1620 * block size of 2**@blocksize_bits) is addressable by the sector_t
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1621 * and page cache of the system. Return 0 if so and -EFBIG otherwise.
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1622 */
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1623 int generic_check_addressable(unsigned blocksize_bits, u64 num_blocks)
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1624 {
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1625 u64 last_fs_block = num_blocks - 1;
25050181b61aa0 Pankaj Raghav 2025-06-30 1626 u64 last_fs_page, max_bytes;
25050181b61aa0 Pankaj Raghav 2025-06-30 1627
25050181b61aa0 Pankaj Raghav 2025-06-30 @1628 if (check_shl_overflow(num_blocks, blocksize_bits, &max_bytes))
25050181b61aa0 Pankaj Raghav 2025-06-30 1629 return -EFBIG;
25050181b61aa0 Pankaj Raghav 2025-06-30 1630
25050181b61aa0 Pankaj Raghav 2025-06-30 1631 last_fs_page = (max_bytes >> PAGE_SHIFT) - 1;
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1632
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1633 if (unlikely(num_blocks == 0))
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1634 return 0;
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1635
25050181b61aa0 Pankaj Raghav 2025-06-30 1636 if (blocksize_bits < 9)
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1637 return -EINVAL;
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1638
a33f13efe05192 Joel Becker 2010-08-16 1639 if ((last_fs_block > (sector_t)(~0ULL) >> (blocksize_bits - 9)) ||
a33f13efe05192 Joel Becker 2010-08-16 1640 (last_fs_page > (pgoff_t)(~0ULL))) {
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1641 return -EFBIG;
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1642 }
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1643 return 0;
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1644 }
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1645 EXPORT_SYMBOL(generic_check_addressable);
30ca22c70e3ef0 Patrick J. LoPresti 2010-07-22 1646
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-12-22 10:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-20 11:02 [PATCH v3 0/3] kbuild: remove gcc's -Wtype-limits Vincent Mailhol
2025-12-20 11:02 ` [PATCH v3 1/3] " Vincent Mailhol
2025-12-20 11:02 ` [PATCH v3 2/3] kbuild: cleanup local -Wno-type-limits exceptions Vincent Mailhol
2025-12-20 12:53 ` Nicolas Schier
2025-12-20 11:02 ` [PATCH v3 3/3] overflow: Remove is_non_negative() and is_negative() Vincent Mailhol
2025-12-20 12:52 ` Nicolas Schier
2025-12-22 10:03 ` kernel test robot [this message]
2025-12-22 18:39 ` Vincent Mailhol
2025-12-22 19:55 ` kernel test robot
2025-12-25 6:04 ` kernel test robot
2025-12-27 8:49 ` kernel test robot
2025-12-28 1:41 ` kernel test robot
2026-01-01 15:10 ` Vincent Mailhol
2026-01-01 19:39 ` Nicolas Schier
2026-01-02 11:04 ` Miguel Ojeda
2026-01-02 22:26 ` Vincent Mailhol
2026-01-02 22:29 ` [PATCH] overflow: Update is_non_negative() and is_negative() comment Vincent Mailhol
2026-01-03 10:02 ` Dan Carpenter
2026-01-03 11:10 ` Vincent Mailhol
2026-01-03 16:56 ` Dan Carpenter
2026-01-03 19:40 ` Vincent Mailhol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202512221735.mRV4BZqB-lkp@intel.com \
--to=lkp@intel.com \
--cc=airlied@gmail.com \
--cc=chris.mason@fusionio.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsterba@suse.com \
--cc=gustavoars@kernel.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mailhol@kernel.org \
--cc=morbo@google.com \
--cc=mripard@kernel.org \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nsc@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).