From: Al Viro <viro@zeniv.linux.org.uk>
To: linux-sparse@vger.kernel.org
Cc: chriscli@google.com, torvalds@linux-foundation.org,
zxh@xh-zhang.com, ben.dooks@codethink.co.uk,
dan.carpenter@linaro.org, rf@opensource.cirrus.com
Subject: [PATCH 08/21] preparing to change argument number encoding for TOKEN_..._ARGUMENT
Date: Mon, 16 Mar 2026 07:04:02 +0000 [thread overview]
Message-ID: <20260316070415.768839-8-viro@zeniv.linux.org.uk> (raw)
In-Reply-To: <20260316070415.768839-1-viro@zeniv.linux.org.uk>
We want to steal some bits from TOKEN_..._ARGUMENT; it's not a problem,
seeing that payload is a 32bit number and we are *not* going to support
many millions of arguments in macros. For now, wrap the accesses into
an inline helper (argnum(token)), to reduce the amount of noise in
subsequent patches.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
pre-process.c | 23 ++++++++++++++---------
token.h | 4 ++++
2 files changed, 18 insertions(+), 9 deletions(-)
diff --git a/pre-process.c b/pre-process.c
index 85662365..efb208e7 100644
--- a/pre-process.c
+++ b/pre-process.c
@@ -624,11 +624,16 @@ static struct token **copy(struct token **where, struct token *list)
return where;
}
+static inline int argnum(const struct token *arg)
+{
+ return arg->argnum >> ARGNUM_BITS_STOLEN;
+}
+
static int handle_kludge(const struct token **p, struct arg *args)
{
const struct token *t = (*p)->next->next;
while (1) {
- struct arg *v = &args[t->argnum];
+ struct arg *v = &args[argnum(t)];
if (token_type(t->next) != TOKEN_CONCAT) {
if (v->arg) {
/* ignore the first ## */
@@ -681,13 +686,13 @@ static struct token **substitute(struct token **list, const struct token *body,
break;
case TOKEN_STR_ARGUMENT:
- arg = args[body->argnum].str;
- count = &args[body->argnum].n_str;
+ arg = args[argnum(body)].str;
+ count = &args[argnum(body)].n_str;
goto copy_arg;
case TOKEN_QUOTED_ARGUMENT:
- arg = args[body->argnum].arg;
- count = &args[body->argnum].n_quoted;
+ arg = args[argnum(body)].arg;
+ count = &args[argnum(body)].n_quoted;
if (!arg || eof_token(arg)) {
if (state == Concat)
state = Normal;
@@ -698,8 +703,8 @@ static struct token **substitute(struct token **list, const struct token *body,
goto copy_arg;
case TOKEN_MACRO_ARGUMENT:
- arg = args[body->argnum].expanded;
- count = &args[body->argnum].n_normal;
+ arg = args[argnum(body)].expanded;
+ count = &args[argnum(body)].n_normal;
if (eof_token(arg)) {
state = Normal;
continue;
@@ -1219,7 +1224,7 @@ static int try_arg(struct token *token, enum token_type type, struct token *argl
for (int i = 0; i < nr; i++)
arglist = arglist->next->next;
- token->argnum = nr;
+ token->argnum = nr << ARGNUM_BITS_STOLEN;
token_type(token) = type;
switch (type) {
case TOKEN_MACRO_ARGUMENT:
@@ -2356,7 +2361,7 @@ static void dump_macro(struct symbol *sym)
/* fall-through */
case TOKEN_QUOTED_ARGUMENT:
case TOKEN_MACRO_ARGUMENT:
- printf("%s", show_ident(args[token->argnum]));
+ printf("%s", show_ident(args[argnum(token)]));
break;
default:
printf("%s", show_token(token));
diff --git a/token.h b/token.h
index 5dcd8594..fe7c7fe9 100644
--- a/token.h
+++ b/token.h
@@ -177,6 +177,10 @@ struct argcount {
unsigned str:10;
};
+enum {
+ ARGNUM_BITS_STOLEN
+};
+
/*
* This is a very common data structure, it should be kept
* as small as humanly possible. Big (rare) types go as
--
2.47.3
next prev parent reply other threads:[~2026-03-16 7:01 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1771930766.git.dan.carpenter@linaro.org>
2026-02-24 11:07 ` [PATCH] sparse: add support for __VA_OPT__ Dan Carpenter
2026-02-24 11:16 ` Ben Dooks
2026-02-24 11:56 ` Dan Carpenter
2026-02-24 12:42 ` Richard Fitzgerald
2026-02-24 13:15 ` Ben Dooks
2026-02-25 2:39 ` Chris Li
2026-02-25 3:36 ` Al Viro
2026-02-25 5:29 ` [RFC PATCH] pre-process: add __VA_OPT__ support Eric Zhang
2026-02-25 6:40 ` Al Viro
2026-02-25 7:27 ` Al Viro
2026-02-25 8:14 ` Eric Zhang
2026-02-25 22:18 ` Al Viro
2026-02-26 7:29 ` Al Viro
2026-03-16 6:56 ` Al Viro
2026-03-16 7:03 ` [PATCH 01/21] split copy() into "need to copy" and "can move in place" cases Al Viro
2026-03-16 7:03 ` [PATCH 02/21] expand and simplify the call of dup_token() in copy() Al Viro
2026-03-16 7:03 ` [PATCH 03/21] more dup_token() optimizations Al Viro
2026-03-16 7:03 ` [PATCH 04/21] parsing #define: saner handling of argument count, part 1 Al Viro
2026-03-16 7:03 ` [PATCH 05/21] simplify collect_arguments() and fix error handling there Al Viro
2026-03-16 7:04 ` [PATCH 06/21] try_arg(): don't use arglist for argument name lookups Al Viro
2026-03-16 7:04 ` [PATCH 07/21] make expand_has_...() responsible for expanding its argument Al Viro
2026-03-16 7:04 ` Al Viro [this message]
2026-03-16 7:04 ` [PATCH 09/21] steal 2 bits from argnum for argument kind Al Viro
2026-03-16 7:04 ` [PATCH 10/21] on-demand argument expansion Al Viro
2026-03-16 7:04 ` [PATCH 11/21] kill create_arglist() Al Viro
2026-03-16 7:04 ` [PATCH 12/21] stop mangling arglist, get rid of TOKEN_ARG_COUNT Al Viro
2026-03-16 7:04 ` [PATCH 13/21] deal with ## on arguments separately Al Viro
2026-03-16 7:04 ` [PATCH 14/21] preparations for __VA_OPT__ support: reshuffle argument slot assignments Al Viro
2026-03-16 7:04 ` [PATCH 15/21] pre-process.c: split try_arg() Al Viro
2026-03-16 7:04 ` [PATCH 16/21] __VA_OPT__: parsing Al Viro
2026-03-16 7:04 ` [PATCH 17/21] expansion-time va_opt handling Al Viro
2026-03-16 7:04 ` [PATCH 18/21] merge(): saner handling of ->noexpand Al Viro
2026-03-16 7:04 ` [PATCH 19/21] simplify the calling conventions of collect_arguments() Al Viro
2026-03-16 7:04 ` [PATCH 20/21] make expand_one_symbol() inline Al Viro
2026-03-16 7:04 ` [PATCH 21/21] substitute(): convert switch() into cascade of ifs Al Viro
2026-03-16 16:42 ` [RFC PATCH] pre-process: add __VA_OPT__ support Linus Torvalds
2026-03-19 3:53 ` Al Viro
2026-03-19 4:07 ` Linus Torvalds
2026-03-19 5:34 ` Al Viro
2026-03-17 7:41 ` Chris Li
2026-03-18 6:35 ` Eric Zhang
2026-02-25 7:05 ` [PATCH] sparse: add support for __VA_OPT__ Chris Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316070415.768839-8-viro@zeniv.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=ben.dooks@codethink.co.uk \
--cc=chriscli@google.com \
--cc=dan.carpenter@linaro.org \
--cc=linux-sparse@vger.kernel.org \
--cc=rf@opensource.cirrus.com \
--cc=torvalds@linux-foundation.org \
--cc=zxh@xh-zhang.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox