Debian package; trivial fixes

Debian package; trivial fixes

[Loïc Minier]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

        Hi,

 I've prepared and uploaded a Debian package for sparse 0.1:
    <http://people.dooz.org/~lool/debian/sparse/0.1-1/sid-pbuilder/>

 FYI, It is currently targetted at Debian "non-free" due to the choice
 of venue clause in the license.  I think the patent clause is slightly
 problematic but might be acceptable for Debian "main".


 Please find attached a trivial fix for .gitignore where "check" wasn't
 renamed to "sparse".

 It would also be more convenient to create BINDIR automatically on make
 install.

   Bye,
-- 
Loïc Minier <lool@dooz.org>

[-- Attachment #2: rename-sparse-in-dot-gitignore.patch --]
[-- Type: text/plain, Size: 241 bytes --]

diff --git a/.gitignore b/.gitignore
index 3e12ce7..665ad03 100644
--- a/.gitignore
+++ b/.gitignore
@@ -11,9 +11,9 @@ pre-process.h
 test-lexing
 test-parsing
 obfuscate
-check
 compile
 graph
+sparse
 test-dissect
 test-linearize
 example

[-- Attachment #3: create-bindir.patch --]
[-- Type: text/plain, Size: 550 bytes --]

diff --git a/Makefile b/Makefile
index 2dcd514..920fe67 100644
--- a/Makefile
+++ b/Makefile
@@ -40,18 +40,12 @@ LIBS=$(LIB_FILE)
 
 all: $(PROGRAMS)
 
-install: $(INST_PROGRAMS) bin-dir
+install: $(INST_PROGRAMS)
+	install -d $(BINDIR)
 	for f in $(INST_PROGRAMS); do \
 		install -v $$f $(BINDIR)/$$f || exit 1; \
 	done
 
-bin-dir:
-	@if ! test -d $(BINDIR); then \
-		echo "No '$(BINDIR)' directory to install in"; \
-		echo "Please create it and add it to your PATH"; \
-		exit 1; \
-	fi
-
 .PHONY: bin-dir
 
 test-lexing: test-lexing.o $(LIBS)

Re: Debian package; trivial fixes

[Josh Triplett]

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

Loïc Minier wrote:
>  I've prepared and uploaded a Debian package for sparse 0.1:
>     <http://people.dooz.org/~lool/debian/sparse/0.1-1/sid-pbuilder/>

Thanks!

>  Please find attached a trivial fix for .gitignore where "check" wasn't
>  renamed to "sparse".
>
>  It would also be more convenient to create BINDIR automatically on make
>  install.

Thanks for these two fixes.

Sparse follows the same Signed-off-by convention as Linux, so coud you
please supply a Signed-off-by for your patches?  See <http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;hb=HEAD;f=Documentation/SubmittingPatches>
for details on the Signed-off-by process and the Developer's Certificate of
Origin.

You might find git convenient for submitting patches.  If you have changes to
Sparse in a git repository, you can create patch mails with "git
format-patch".  git also makes Signed-off-by as simple as adding -s to the
"git commit" or "cg commit" command line.

Thanks,
Josh Triplett


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

Re: Debian package; trivial fixes

[Josh Triplett]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

Loïc Minier wrote:
>  It would also be more convenient to create BINDIR automatically on make
>  install.
[...]
> -bin-dir:
> -	@if ! test -d $(BINDIR); then \
> -		echo "No '$(BINDIR)' directory to install in"; \
> -		echo "Please create it and add it to your PATH"; \
> -		exit 1; \
> -	fi
> -
>  .PHONY: bin-dir

The .PHONY line for bin-dir should go away too.

- Josh Triplett



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]