Re: [PATCH 3] Add instruction to pseudo user tracking.

[Josh Triplett <josh@freedesktop.org>]

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

Christopher Li wrote:
> The current way of tracking pseudo register user is by
> keeping a list of the address of the pseudo_t member.
> This address can be in part of the instruction member, the
> worse case is in the argument list of the call instruction.
> 
> As the comment for address_taken() said, using the container
> to get instruction pointer is wrong. It use to work with instruction
> that relate to symbol address. But that is not true any more. Even
> worse, it is very hard to track the pseudo usage other than symbol
> address. The only reason symbol address used to works for call instruction
> is because call instruction did not directly use the symbol address.
> 
> I bit the bullet and just add the instruction pointer to pair with
> the pseudo user pointer. So it will work with the case that the
> user instruction is call as well.

Good call; merged.  Thanks.

- Josh Triplett



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]