From: Josh Triplett <josh@freedesktop.org>
To: Christopher Li <sparse@chrisli.org>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [PATCH 7] Allow more than one command line include file.
Date: Sat, 27 Jan 2007 00:39:40 -0800 [thread overview]
Message-ID: <45BB0FCC.1090700@freedesktop.org> (raw)
In-Reply-To: <20070117024005.GG962@chrisli.org>
[-- Attachment #1: Type: text/plain, Size: 853 bytes --]
Christopher Li wrote:
> --- sparse.orig/lib.c 2006-12-05 16:17:39.000000000 -0800
> +++ sparse/lib.c 2006-12-22 01:51:00.000000000 -0800
> @@ -192,7 +192,10 @@ int Wdo_while = 1;
> int Wuninitialized = 1;
> int preprocess_only;
> char *include;
> -int include_fd = -1;
> +
> +#define CMDLINE_INCLUDE 20
> +int cmdline_include_nr = 0;
> +struct cmdline_include cmdline_include[CMDLINE_INCLUDE];
[...]
I've accepted this patch for now, since a larger finite limit will solve the
current problem. I'd really like to see something which handles an arbitrary
number of include files, though. Also, ideally Sparse could read each
filename, parse that include file, and close it, rather than keeping all the
include files open; doing something like that might even avoid the need to
keep them around in an array.
- Josh Triplett
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]
prev parent reply other threads:[~2007-01-27 8:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-17 2:40 [PATCH 7] Allow more than one command line include file Christopher Li
2007-01-27 8:39 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45BB0FCC.1090700@freedesktop.org \
--to=josh@freedesktop.org \
--cc=linux-sparse@vger.kernel.org \
--cc=sparse@chrisli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).