Re: Bogus sparse warning?

[Josh Triplett <josh@freedesktop.org>]

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

Christopher Li wrote:
> On Tue, Feb 13, 2007 at 12:22:44AM -0800, Josh Triplett wrote:
>> Anton reported success with this revision of your patch, so I'd like to apply
>> it to the sparse tree; could you please supply a Signed-off-by so I can do so?
> 
> Bug fix in pointer modifiers inherent at function degeneration.
> 
> In reply to Randy's email:
> 
> The following case cause warning about different signedness of pointer.
> The pointer should not have signedness at all.
> 
> struct sk_buff;
> struct sock;
> 
> extern int skb_append_datato_frags(struct sock *sk, struct sk_buff *skb,
> 			int getfrag(void *from, char *to, int offset,
> 			int len,int odd, struct sk_buff *skb),
> 			void *from, int length);
> 
> int skb_append_datato_frags(struct sock *sk, struct sk_buff *skb,
> 			int (*getfrag)(void *from, char *to, int offset,
> 			int len,int odd, struct sk_buff *skb),
> 			void *from, int length)
> 
> {
> 	return 0;
> }
> 
> Singed-Off-By: Christopher Li <sparse@chrisli.org>
> Acked-By: Linus Torvalds <torvalds@linux-foundation.org>

Applied.  I also added this test case to the validation directory.

Thanks.

- Josh Triplett


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]